Remove usingnamespace usage and fixup build script / callconv deprecations#37
Merged
hazeycode merged 3 commits intozig-gamedev:mainfrom Jul 20, 2025
Merged
Remove usingnamespace usage and fixup build script / callconv deprecations#37hazeycode merged 3 commits intozig-gamedev:mainfrom
hazeycode merged 3 commits intozig-gamedev:mainfrom
Conversation
- Fixup build script, callconv deprecations
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the zglfw codebase to be compatible with Zig 0.15.x by removing the deprecated usingnamespace feature and updating build script patterns. The changes also address callconv deprecations by updating from .C to .c.
Key changes include:
- Replacing
usingnamespacewith explicit@exportcalls for Emscripten compatibility functions - Updating all callback function calling conventions from
.Cto.c - Modernizing build.zig to use newer
addLibraryAPI instead of separate static/shared library functions
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/zglfw.zig | Updates calling conventions, removes usingnamespace, adds getInputMode functions, and refactors Emscripten compatibility code |
| build.zig | Modernizes library creation using addLibrary API and createModule pattern |
Comments suppressed due to low confidence (1)
src/zglfw.zig:1235
- The parameter names use anonymous underscores which makes the function signature unclear. Consider using descriptive parameter names like 'joystick_id' and 'state' to improve code readability.
fn glfwGetGamepadState(_: i32, _: ?*anyopaque) callconv(.c) i32 {
Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of 0.15.x
usingnamespacehas been removed: ziglang/zig#20663