docs: fix generate_session argument naming in examples#217
Open
Adithya-bs wants to merge 1 commit intozerodha:masterfrom
Open
docs: fix generate_session argument naming in examples#217Adithya-bs wants to merge 1 commit intozerodha:masterfrom
Adithya-bs wants to merge 1 commit intozerodha:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #216
Overview
This PR fixes a naming discrepancy in the
examples/directory. Thegenerate_sessionmethod was being called with the incorrect keyword argumentsecret=, which results in aTypeError.In the actual library implementation (
kiteconnect/connect.py), the parameter is defined asapi_secret.Changes
The argument name has been updated from
secrettoapi_secretin the following example scripts to ensure they are functional for users:examples/simple.pyexamples/gtt_order.pyexamples/order_margins.pyVerification
Checked the method signature in
connect.py:def generate_session(self, request_token, api_secret):The examples now correctly align with the library's method signature.