Refactor HTTP Accept-Encoding header parsing#542
Draft
Woazboat wants to merge 3 commits intozerebubuth:masterfrom
Draft
Refactor HTTP Accept-Encoding header parsing#542Woazboat wants to merge 3 commits intozerebubuth:masterfrom
Woazboat wants to merge 3 commits intozerebubuth:masterfrom
Conversation
Prioritize encodings in order sent by client 'identity' encoding is always valid unless explicitly forbidden Fixes zerebubuth#540
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement a generic HTTP list header parser and use it to replace the current Accept-Encoding header parsing.
Properly handle optional whitespace in list items/parameters. Prioritize encodings in order requested by user (#540 (comment)).
Change encoding classes to singletons since they are only used as factories and don't hold any state.
Requires GCC version 12 to make
std::ranges::views::splitactually usableGCC 12 is available in Ubuntu 22.04 used in CI, but GCC 11 is still used as the default
(GCC 12 is also required for constexpr
std::string/std::vector, but those aren't really necessary.)https://en.cppreference.com/w/cpp/20.html
Fixes #540