feat: improve HTML semantics and buttons animation#428
feat: improve HTML semantics and buttons animation#428SebastianL-dev wants to merge 2 commits intozen-browser:mainfrom
Conversation
SebastianL-dev
commented
Jan 23, 2025
- Improved HTML semantics and fix buttons hover transition.
|
Hi! Could we see how it look now? |
|
Hey, the design its the same, i just fixed some HTML semantics, and the buttons transitions its better, before all buttons have no transitions, now have fade transition on hover. Screen.Recording.2025-01-24.213418.mp4It's a little change but i think that look much better. |
|
Doesn't it break the initial animations though? |
|
Nope, it doesn't, you can see it in the video 😊 |
|
Hey, nice work! This change seems fine for the most part, but it does break the color of the "Start Exploring" button. On the main version, it's dark (to contrast it from the "Download" button), but on your version, it's light. Shouldn't be too hard to fix. There might be some other color issues too, but that's the main one that I noticed. |
|
Hey, sorry for that, i didn't realize about that, i will fix it and update this pull request, thank you. 😊 |
Screen.Recording.2025-01-27.135619.mp4Hey, i fixed the transitions, now the transitions looks better and it doesn't break the contrast. |