feat(ui): add zoom in/out buttons and menu#1266
feat(ui): add zoom in/out buttons and menu#1266Serge45 wants to merge 2 commits intozealdocs:mainfrom
Conversation
|
Thanks for looking into this. I think adding more buttons to the toolbar results in UI clutter. Nowadays major browsers moved to one menu button. I'd say Zeal should follow the trend. That would also allow us to address #1251. Would you be willing to give menu button try? |
|
Thanks, this is a good idea, I will move those buttons to a menu button ASAP. |
trollixx
left a comment
trollixx
left a comment
There was a problem hiding this comment.
Looks good! I've added a few minor requests. Also please squash and rebase your changes. Thanks!
Serge45
force-pushed
the
feat/zoom-buttons
branch
2 times, most recently
from
b1b3c74 to
1957dd2
Compare
trollixx
left a comment
trollixx
left a comment
There was a problem hiding this comment.
Nice! Thank you! I have some nitpicks and small things I'd like to try. Is it okay if push my changes directly to this PR? I can also leave a detailed review but that might take longer.
|
Ok, sure. There are some ugly codes to make widget in |
trollixx
force-pushed
the
feat/zoom-buttons
branch
from
24ca95a to
b6aeec4
Compare
trollixx
force-pushed
the
feat/zoom-buttons
branch
from
b6aeec4 to
be8af52
Compare
trollixx
changed the title
trollixx
changed the title
An event filter was also added to prevent pop-up menu closing while zoom in/out actions triggered.
A custom QStyleSheet must be applied to BrowserZoomWidget since QMenu does not handle item highlighting of QWidget in QWidgetAction.
trollixx
force-pushed
the
feat/zoom-buttons
branch
from
be8af52 to
ee6c552
Compare
2 participants
As requested in #1256, I added zoom in, zoom out and reset zoom items to the edit menu. Two convenient tool buttons for zoom in and zoom out were added to browser tab as well.