Fix display_image method ignoring duration.#48
Open
gimait wants to merge 6 commits intozayfod:devfrom
Open
Conversation
Signed-off-by: Aitor Miguel Blanco <aitormibl@gmail.com>
reakain
added a commit
to reakain/pycozmo
that referenced
this pull request
Sep 1, 2023
MemezForBeanz
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comments in #45 noted that the
Client.display_imagemethod was failing to show the image for the set duration.Looking into the code, I saw that this happened when
procedural_face_enabledwas set because theAnimationControllerloop would start fetching new face images.I used the
playing_animationvariable ofAnimationControllerto prevent this from happening.Now,
Client.display_imagestarts the animation and clears the screen if a duration is set. If no duration is specified, theClient.clear_screenfunction should be called to stop showing the image.It should also be noted that right now sending a new image or starting an animation will override the previously shown image, but I think this is probably the most intuitive way to work with it as well.