Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Claude configuration to disable adaptive thinking, modifies the global gitignore to include .codex patterns, and bumps several Neovim plugin versions in the lockfile. Feedback was provided regarding the gitignore logic for .codex, noting that the current combination of ignore and unignore rules might not correctly handle the directory and its contents.
| .codex | ||
| !.codex/ |
There was a problem hiding this comment.
The combination of .codex followed by !.codex/ will ignore a file named .codex but will explicitly not ignore a directory named .codex/. If .codex is a directory (which is common for AI tool metadata), this configuration will not prevent its contents from being tracked by Git. If the intent is to ignore the directory and its contents, the unignore rule should be removed.
.codex/
There was a problem hiding this comment.
Pull request overview
Updates ignore rules and AI tool configuration in this dotfiles repo, alongside routine Neovim plugin lockfile bumps.
Changes:
- Add
.codexpatterns to the global gitignore. - Update Claude Code settings env vars.
- Bump multiple pinned Neovim plugin commits in
lazy-lock.json.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.config/nvim/lazy-lock.json |
Updates pinned commits for several Neovim plugins. |
.config/git/gitignore_global |
Adds global ignore rules related to Codex artifacts. |
.config/claude/settings.json |
Adds an additional Claude Code environment toggle. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| .codex | ||
| !.codex/ |
There was a problem hiding this comment.
The patterns .codex followed by !.codex/ result in .codex/ directories NOT being ignored (only a file literally named .codex remains ignored). If the intent is to ignore Codex’s directory, switch to .codex/ (and drop the negation). If the intent is specifically “ignore .codex file but allow .codex/ dir”, please add an inline comment explaining that, because the current rule pair is non-obvious and easy to misinterpret.
| .codex | |
| !.codex/ | |
| .codex/ |
| { | ||
| "Comment.nvim": { "branch": "master", "commit": "e30b7f2008e52442154b66f7c519bfd2f1e32acb" }, | ||
| "CopilotChat.nvim": { "branch": "main", "commit": "0b3133ffbb470b1616c47170b544d0b9a3bbcf5b" }, | ||
| "CopilotChat.nvim": { "branch": "main", "commit": "5378035c2eb4089de245473dec1768e0986543bd" }, | ||
| "LspUI.nvim": { "branch": "main", "commit": "946fdfc6cdab03681fc9aafb21cc7086d93509b7" }, | ||
| "LuaSnip": { "branch": "master", "commit": "a62e1083a3cfe8b6b206e7d3d33a51091df25357" }, | ||
| "blink-copilot": { "branch": "main", "commit": "7ad8209b2f880a2840c94cdcd80ab4dc511d4f39" }, | ||
| "blink-ripgrep.nvim": { "branch": "main", "commit": "13b3e890755a1d1e4947d984b129e9defe787366" }, | ||
| "blink-ripgrep.nvim": { "branch": "main", "commit": "d84a20e765fdc9cc8c0775708e083e7185654527" }, | ||
| "blink.cmp": { "branch": "main", "commit": "78336bc89ee5365633bcf754d93df01678b5c08f" }, | ||
| "blink.lib": { "branch": "main", "commit": "a459c8fbf51359902971874b5ebe05f6602db8b4" }, | ||
| "blink.lib": { "branch": "main", "commit": "b7c3a6cd97c9dd83e774308891643ae6f7ea2de8" }, |
There was a problem hiding this comment.
PR title indicates this is only updating gitignore for Codex, but this change set also updates Neovim’s lazy-lock.json plugin pins. If those lockfile bumps are intentional, the PR title/description should reflect that; otherwise consider reverting/splitting the lockfile updates to keep the PR focused.
| "DISABLE_AUTOUPDATER": "true", | ||
| "DISABLE_MICROCOMPACT": "true", | ||
| "DISABLE_INTERLEAVED_THINKING": "true", | ||
| "CLAUDE_CODE_EXPERIMENTAL_AGENT_TEAMS": "1" | ||
| "CLAUDE_CODE_EXPERIMENTAL_AGENT_TEAMS": "1", | ||
| "CLAUDE_CODE_DISABLE_ADAPTIVE_THINKING": "1" | ||
| }, |
There was a problem hiding this comment.
PR title indicates this is only a gitignore update, but this file also changes Claude Code runtime behavior by adding CLAUDE_CODE_DISABLE_ADAPTIVE_THINKING. If this is intentional, please update the PR title/description (or split into a separate PR) so reviewers understand the behavior change being introduced.
No description provided.