Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a broken/incorrect standalone Home Manager host configuration and updates documentation/agent rules so users (and tools) invoke flake-based Home Manager configs correctly when environment-variable overrides are involved.
Changes:
- Fix the
X1C10host to use a Home Manager–specific module and remove the invalid NixOS-onlyprograms.nix-ldoption. - Update user-facing instructions to use
--impurewhen overridingNIX_USERNAME/NIX_DOTFILES_PATH. - Adjust agent/lint guidance and Codex rules; update Neovim plugin lockfile revisions.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| install.sh | Updates “next steps” instructions for standalone Home Manager to include --impure when using env overrides. |
| home-manager/hosts/X1C10.nix | Removes NixOS-only option from a standalone Home Manager host module (now effectively a no-op module with rationale). |
| flake.nix | Corrects X1C10 host attributes to use hostSpecificHomeConfig; updates usage comments. |
| README.md | Documents --impure requirement when overriding username/dotfiles path via environment variables. |
| AGENTS.md | Updates local development commands (lint/apply) and host naming examples. |
| .config/nvim/lazy-lock.json | Bumps pinned commits for several Neovim plugins. |
| .config/codex/rules/default.rules | Allows additional command prefixes (notably nix eval / nix flake) for Codex runs. |
| .config/codex/AGENTS.md | Tweaks response-style guidance for Codex agents (numbered lists preference, etc.). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - **Lint shell**: `git ls-files -z -- '*.sh' | xargs -0 shellcheck`. | ||
| - **Lint zsh**: `find .config/zsh/.zshrc .config/zsh/rc -maxdepth 1 -type f -print0 | xargs -0 shellcheck -f gcc`. | ||
| - **Lint Lua**: `git ls-files -z -- '*.lua' | xargs -0 selene -q`. | ||
| - **Format Nix**: `nixfmt --check $(git ls-files '*.nix')` (use RFC-style). |
| "mini.surround": { "branch": "main", "commit": "88c52297ed3e69ecf9f8652837888ecc727a28ee" }, | ||
| "modicator.nvim": { "branch": "main", "commit": "7f867b4980946f115f4ccb922637d70d89a59cb4" }, | ||
| "neoconf.nvim": { "branch": "main", "commit": "b5652592c3a79ebc9dc6336a769744b35788ea77" }, | ||
| "neoconf.nvim": { "branch": "main", "commit": "ecdb0c9bc3f3373e11be4c97e461d16b52d532d0" }, |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates documentation and configuration for Home Manager and Nix flakes, notably adding the --impure flag to commands using custom environment variables and refining linting procedures. It also updates Neovim plugin locks and corrects host configuration paths. Feedback was provided to improve the zsh linting command by using git ls-files for consistency and specifying a shell dialect for shellcheck to handle files without shebangs.
| - **Lint shell**: `find . -name "*.sh" -print0 | xargs -0 shellcheck`. | ||
| - **Lint Lua**: `selene -q .`. | ||
| - **Lint shell**: `git ls-files -z -- '*.sh' | xargs -0 shellcheck`. | ||
| - **Lint zsh**: `find .config/zsh/.zshrc .config/zsh/rc -maxdepth 1 -type f -print0 | xargs -0 shellcheck -f gcc`. |
There was a problem hiding this comment.
The shellcheck command for zsh files may not work as expected because shellcheck requires a shebang to detect the shell dialect, which .zshrc and other configuration snippets typically lack. Additionally, shellcheck does not natively support zsh syntax, so it is common practice to specify a supported dialect like -s bash to catch general logic errors. For consistency with the other linting commands in this file, consider using git ls-files instead of find.
| - **Lint zsh**: `find .config/zsh/.zshrc .config/zsh/rc -maxdepth 1 -type f -print0 | xargs -0 shellcheck -f gcc`. | |
| - **Lint zsh**: git ls-files -z -- '.config/zsh/.zshrc' '.config/zsh/rc/' | xargs -0 shellcheck -f gcc -s bash |
No description provided.