This modifications fix the use of regex with glob on windows.

[jrubstein]

Getting the test by URL and finding the base file of the test to inject inject.js were done using the path as string. Since windows uses '' instead of '/' the script was never injected.

[yahoocla]

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄

[jrubstein]

The CLA was sent.

[reid]

Thanks! I'll review this by the end of tomorrow.

On Aug 11, 2014, at 4:10 PM, jrubstein notifications@github.com wrote:

The CLA was sent.

—
Reply to this email directly or view it on GitHub.

[reid]

Please use double-quotes. Thank you!

[yahoocla]

CLA is valid!

[reid]

Same here.

[reid]

This looks good. Please match existing quote style and I'll get this merged in and released.

Thanks so much for fixing this! 😃

[jrubstein]

Hello @reid , all the changes were done and pushed.
Regards,
Jonathan.

[jrubstein]

Hello @reid , Were you able to check the modifications?
Regards,
Jonathan.

[reid]

Thanks for the ping @jrubstein! I'll review this today.

[reid]

Hey @jrubstein, your changes passed tests locally with a old set of npm dependencies. I have attempted to test with a clean npm install but the test suite hangs. This will require more investigation.

The hang is likely due to a new dependency being loaded that breaks the test suite.

I will look into this over the weekend, but feel free to help if you can! Otherwise, I'll get back to you about what I find next week.

[jrubstein]

@reid do you have any updates regarding this pull request?
Thanks
Jonathan.