Skip to content

Conversation

@samdark
Copy link
Member

@samdark samdark commented Oct 24, 2025

--prune makes removing unused container that are no longer in the stack.

--detach=false make the command actually get the output from the Docker Swarm about how actual deployment goes and errors if any. Previously it was existing with success as long as compose file was sent.

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

@samdark samdark requested review from Copilot and vjik October 24, 2025 14:11
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the production deployment command to add explicit pruning of stale containers and disable detached mode for better deployment feedback. The changes ensure that old containers are cleaned up automatically and that deployment progress is visible in the console.

Key Changes:

  • Modified the docker stack deploy command to include --prune for automatic cleanup of orphaned containers
  • Added explicit --detach=false flag to ensure synchronous deployment with visible output

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.22%. Comparing base (0a573b7) to head (55d7cd2).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #250      +/-   ##
============================================
- Coverage     78.07%   77.22%   -0.86%     
  Complexity       52       52              
============================================
  Files            16       16              
  Lines           187      180       -7     
============================================
- Hits            146      139       -7     
  Misses           41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add line to changelog

@samdark samdark requested a review from vjik October 25, 2025 19:11
@samdark samdark merged commit e36fda9 into master Oct 27, 2025
16 of 17 checks passed
@samdark samdark deleted the swarm-prune-no-detach branch October 27, 2025 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants