Skip to content

Prepare allsorts-tools for MORX testing #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adrianwong merged 3 commits into from
Mar 19, 2025
Merged

Prepare allsorts-tools for MORX testing #43

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b61e7c6
svg: Fix swapped script and lang tags for SHLANA tests
adrianwong Mar 14, 2025
9fdd7ea
svg: Pass SvgOpts to script_and_lang_from_testcase
adrianwong Mar 14, 2025
f3430a2
svg: Identify use of Hebrew input in MORX-{37,38,39,40} tests
adrianwong Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 21 additions & 7 deletions src/svg.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const FONT_SIZE: f32 = 1000.0;
pub fn main(opts: SvgOpts) -> Result<i32, BoxError> {
// Read and parse the font
let (buffer, tuple) = load_font_maybe_instance(&opts)?;
let (script, lang) = script_and_lang_from_testcase(&opts.testcase);
let (script, lang) = script_and_lang_from_testcase(&opts);
let scope = ReadScope::new(&buffer);
let font_file = scope.read::<FontData<'_>>()?;
let provider = font_file.table_provider(0)?;
Expand Down Expand Up @@ -115,21 +115,35 @@ pub fn main(opts: SvgOpts) -> Result<i32, BoxError> {
Ok(0)
}

fn script_and_lang_from_testcase(testcase: &str) -> (u32, u32) {
if testcase.starts_with("SHARAN") {
fn script_and_lang_from_testcase(opts: &SvgOpts) -> (u32, u32) {
if opts.testcase.starts_with("SHARAN") {
(tag::ARAB, tag::from_string("URD ").unwrap())
} else if testcase.starts_with("SHBALI") {
} else if opts.testcase.starts_with("SHBALI") {
(
tag::from_string("bali").unwrap(),
tag::from_string("BAN ").unwrap(),
)
} else if testcase.starts_with("SHKNDA") {
} else if opts.testcase.starts_with("SHKNDA") {
(tag::KNDA, tag::from_string("KAN ").unwrap())
} else if testcase.starts_with("SHLANA") {
} else if opts.testcase.starts_with("SHLANA") {
(
tag::from_string("THA ").unwrap(),
tag::from_string("lana").unwrap(),
tag::from_string("THA ").unwrap(),
)
} else if opts.testcase.starts_with("MORX-37")
|| opts.testcase.starts_with("MORX-38")
|| opts.testcase.starts_with("MORX-39")
|| opts.testcase.starts_with("MORX-40")
{
// HACK: test input is a mix of Hebrew and English text, and is repeated for all four tests.
if opts.render.contains("ב") {
(
tag::from_string("hebr").unwrap(),
tag::from_string("IWR ").unwrap(),
)
} else {
(tag::LATN, tag::from_string("ENG ").unwrap())
}
} else {
(tag::LATN, tag::from_string("ENG ").unwrap())
}
Expand Down