allow newer libmicrohttpd versions and do not fail if ipv6 stack is not available#787
Merged
rkhapov merged 4 commits intoyandex:masterfrom Apr 14, 2025
Merged
allow newer libmicrohttpd versions and do not fail if ipv6 stack is not available#787rkhapov merged 4 commits intoyandex:masterfrom
rkhapov merged 4 commits intoyandex:masterfrom
Conversation
Contributor
Author
|
@rkhapov 🙏 |
x4m
approved these changes
Apr 11, 2025
Collaborator
|
plz make apply-fmt |
Contributor
Author
|
@x4m done! |
rkhapov
approved these changes
Apr 14, 2025
Contributor
Author
|
wow. I did run apply fmt O_o. Thats odd |
Collaborator
|
@evkuzin it is better to do |
Contributor
Author
|
Yeah |
Collaborator
|
@evkuzin yes, we should delete deprecated apply_fmt... if you want, you can remove apply_fmt in this pr |
Contributor
Author
|
@rkhapov done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
two fixes in one go.
First of all, we are running a new libmicrohttpd lib and it switched to enum. hence the change. (similar to digitalocean/prometheus-client-c#65, which is unfortunately not accepted for ages 😢 )
Also, I see Odyssey erroring and exiting if I try to enable Prometheus on a machine without an Ipv6 stack. Hence the second change. Thx for review in advance!