added cmd line option to split video on keyframes for seamless rejoin#974
Open
hennyg888 wants to merge 1 commit intoxinntao:masterfrom
Open
added cmd line option to split video on keyframes for seamless rejoin#974hennyg888 wants to merge 1 commit intoxinntao:masterfrom
hennyg888 wants to merge 1 commit intoxinntao:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an option to the video inference script to split the video only on keyframes.
Currently it doesn't split on keyframes which can cause extra, missing frames and audio desync, choppy audio, or noise pops on video segment borders. Basically the split isn't on the precise timestamped keyframes so it may have overlaps, missing frames, and the audio doesn't sync up.
e.g.
#404
#388
Using
-f segment -segment_timeswill split only along keyframes but will not be perfectly equal N=num_process pieces. Some pieces may be longer or shorter depending on keyframe distribution.Triggered by command-line option
--keyframe_split.Resulting part videos start and end on keyframes to ensure seamless rejoining after upscaling. Local testing shows no more audio desync and no frame loss / duplication.