Skip to content

Conversation

@pkscout
Copy link
Member

@pkscout pkscout commented Jan 2, 2026

Description

  • Piers and later update
  • added full list of audio codec support
  • rearranged settings

Checklist:

  • x ] My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [script.foo.bar] 1.0.0

- Piers and later update
- added full list of audio codec support
- rearranged settings
@pkscout
Copy link
Member Author

pkscout commented Jan 2, 2026

Ah the joys of code review when uploading an existing addon to a new repo. This is actually a pretty minor update to allow folks to pick all the codecs Piers supports. Here's a diff to make it a bit easier to figure out what to review:

diff -ru script.audio.profiles/addon.xml script.audio.profiles-Omega/addon.xml
--- script.audio.profiles/addon.xml	2026-01-02 17:30:59
+++ script.audio.profiles-Omega/addon.xml	2025-12-23 15:56:10
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8" standalone="yes"?>
-<addon id="script.audio.profiles" name="Audio Profiles" version="2.2.0" provider-name="pkscout, notoco, Regss">
+<addon id="script.audio.profiles" name="Audio Profiles" version="2.1.2" provider-name="pkscout, notoco, Regss">
 	<requires>
         <import addon="xbmc.python" version="3.0.0" />
 	</requires>
@@ -7,10 +7,8 @@
 	<extension point="xbmc.service" library="service.py" />
 	<extension point="xbmc.addon.metadata">
 		<news>
-v.2.2.0
-- this update is for Kodi 22 Piers and later
-- added full list of audio codec support
-- rearranged settings
+v.2.1.2
+- fix for DTS and DTSHD not being properly detected
 		</news>
 		<assets>
 			<icon>icon.png</icon>
diff -ru script.audio.profiles/changelog.txt script.audio.profiles-Omega/changelog.txt
--- script.audio.profiles/changelog.txt	2026-01-02 17:30:59
+++ script.audio.profiles-Omega/changelog.txt	2025-12-23 15:56:10
@@ -1,8 +1,3 @@
-v.2.2.0
-- Piers and later update
-- added full list of audio codec support
-- rearranged settings
-
 v.2.1.2
 - fix for DTS and DTSHD not being properly detected
 
diff -ru script.audio.profiles/resources/language/resource.language.en_gb/strings.po script.audio.profiles-Omega/resources/language/resource.language.en_gb/strings.po
--- script.audio.profiles/resources/language/resource.language.en_gb/strings.po	2026-01-02 17:30:59
+++ script.audio.profiles-Omega/resources/language/resource.language.en_gb/strings.po	2025-12-23 15:56:10
@@ -15,7 +15,7 @@
 
 #: Settings
 msgctxt "#32000"
-msgid "Profiles"
+msgid "Profiles 1-5"
 msgstr ""
 
 #: Settings
@@ -250,7 +250,7 @@
 
 #: Settings
 msgctxt "#32049"
-msgid "Channel Detection"
+msgid "By number of channels"
 msgstr ""
 
 #: Settings
@@ -377,116 +377,6 @@
 #: Settings
 msgctxt "#32074"
 msgid "match streams with no codec details as music"
-msgstr ""
-
-#: Settings
-msgctxt "#32075"
-msgid "Profile for Dolby TrueHD with Atmos"
-msgstr ""
-
-#: Settings
-msgctxt "#32076"
-msgid "The codec entry for this option is truehd_atmos"
-msgstr ""
-
-#: Settings
-msgctxt "#32077"
-msgid "Profile for DTS:X IMAX Enhanced"
-msgstr ""
-
-#: Settings
-msgctxt "#32078"
-msgid "The codec entry for this option is dtshd_ma_x_imax"
-msgstr ""
-
-#: Settings
-msgctxt "#32079"
-msgid "Profile for DTS:X"
-msgstr ""
-
-#: Settings
-msgctxt "#32080"
-msgid "The codec entry for this option is dtshd_ma_x"
-msgstr ""
-
-#: Settings
-msgctxt "#32081"
-msgid "Profile for Lossless FLAC"
-msgstr ""
-
-#: Settings
-msgctxt "#32082"
-msgid "The codec entry for this option is flac"
-msgstr ""
-
-#: Settings
-msgctxt "#32083"
-msgid "Profile for Dolby TrueHD"
-msgstr ""
-
-#: Settings
-msgctxt "#32084"
-msgid "The codec entry for this option is truehd"
-msgstr ""
-
-#: Settings
-msgctxt "#32085"
-msgid "Profile for DTS-HD Master Audio"
-msgstr ""
-
-#: Settings
-msgctxt "#32086"
-msgid "The codec entry for this option is dtshd_ma"
-msgstr ""
-
-#: Settings
-msgctxt "#32087"
-msgid "Profile for DTS-HD High Resolution Audio"
-msgstr ""
-
-#: Settings
-msgctxt "#32088"
-msgid "The codec entry for this option is dtshd_hra"
-msgstr ""
-
-#: Settings
-msgctxt "#32089"
-msgid "Profile for Dolby Digital Plus with Atmos"
-msgstr ""
-
-#: Settings
-msgctxt "#32090"
-msgid "The codec entry for this option is eac3_ddp_atmos"
-msgstr ""
-
-#: Settings
-msgctxt "#32091"
-msgid "Profile for Dolby Digital Plus"
-msgstr ""
-
-#: Settings
-msgctxt "#32092"
-msgid "The codec entry for this option is eac3"
-msgstr ""
-
-#: Settings
-msgctxt "#32093"
-msgid "Profile for DTS"
-msgstr ""
-
-#: Settings
-msgctxt "#32094"
-msgid "The codec entry for this option is dca"
-msgstr ""
-
-#: Settings
-msgctxt "#32095"
-msgid "Profile for Dolby Digital"
-msgstr ""
-
-#: Settings
-msgctxt "#32096"
-msgid "The codec entry for this option is ac3"
 msgstr ""
 
 #: Script
diff -ru script.audio.profiles/resources/lib/apsettings.py script.audio.profiles-Omega/resources/lib/apsettings.py
--- script.audio.profiles/resources/lib/apsettings.py	2026-01-02 17:30:59
+++ script.audio.profiles-Omega/resources/lib/apsettings.py	2025-12-23 15:56:10
@@ -45,17 +45,10 @@
                 {'name': 'auto_unknown', 'default': '0'},
                 {'name': 'codec_delay', 'default': 2},
                 {'name': 'auto_ac3', 'default': '0'},
-                {'name': 'auto_dca', 'default': '0'},
                 {'name': 'auto_eac3', 'default': '0'},
-                {'name': 'auto_eac3_ddp_atmos', 'default': '0'},
-                {'name': 'auto_dtshd_hra', 'default': '0'},
-                {'name': 'auto_dtshd_ma', 'default': '0'},
+                {'name': 'auto_dts', 'default': '0'},
+                {'name': 'auto_dtshd', 'default': '0'},
                 {'name': 'auto_truehd', 'default': '0'},
-                {'name': 'auto_flac', 'default': '0'},
-                {'name': 'auto_dtshd_ma_x', 'default': '0'},
-                {'name': 'auto_dtshd_ma_x_imax', 'default': '0'},
-                {'name': 'auto_dtshd_ma_x_imax', 'default': '0'},
-                {'name': 'auto_truehd_atmos', 'default': '0'},
                 {'name': 'auto_othercodec', 'default': '0'},
                 {'name': 'auto_stereo', 'default': '0'},
                 {'name': 'auto_multichannel', 'default': '0'},
diff -ru script.audio.profiles/resources/lib/audioprofiles.py script.audio.profiles-Omega/resources/lib/audioprofiles.py
--- script.audio.profiles/resources/lib/audioprofiles.py	2026-01-02 17:30:59
+++ script.audio.profiles-Omega/resources/lib/audioprofiles.py	2025-12-23 15:56:10
@@ -147,9 +147,11 @@
                     (str(codec), str(channels))])
         if codec:
             codec_set = 'auto_othercodec'
-            for check_codec in ['ac3', 'dca', 'eac3', 'eac3_ddp_atmos', 'dtshd_hra', 'dtshd_ma', 'truehd', 'flac', 'dtshd_ma_x', 'dtshd_ma_x_imax', 'truehd_atmos']:
+            for check_codec in ['dtshd', 'truehd', 'ac3', 'eac3', 'dts', 'dca']:
                 self.LW.log(['checking %s against %s' % (codec, check_codec)])
-                if codec == check_codec:
+                if codec.startswith(check_codec):
+                    if check_codec == 'dca':
+                        check_codec = 'dts'
                     codec_set = 'auto_%s' % check_codec
                     break
         else:
diff -ru script.audio.profiles/resources/settings.xml script.audio.profiles-Omega/resources/settings.xml
--- script.audio.profiles/resources/settings.xml	2026-01-02 17:30:59
+++ script.audio.profiles-Omega/resources/settings.xml	2025-12-23 15:56:10
@@ -103,6 +103,10 @@
 						<heading>32052</heading>
 					</control>
 				</setting>
+			</group>
+		</category>
+		<category help="" id="profiles 6-10" label="32070">
+			<group id="1">
 				<setting help="" id="profile6" label="32053" type="boolean">
 					<level>0</level>
 					<default>false</default>
@@ -579,7 +583,7 @@
 						<popup>false</popup>
 					</control>
 				</setting>
-				<setting help="32096" id="auto_ac3" label="32095" type="integer">
+				<setting help="" id="auto_ac3" label="32064" type="integer">
 					<level>0</level>
 					<default>0</default>
 					<constraints>
@@ -599,10 +603,10 @@
 						</options>
 					</constraints>
 					<control format="string" type="list">
-						<heading>32095</heading>
+						<heading>32064</heading>
 					</control>
 				</setting>
-				<setting help="32092" id="auto_eac3" label="32091" type="integer">
+				<setting help="" id="auto_eac3" label="32065" type="integer">
 					<level>0</level>
 					<default>0</default>
 					<constraints>
@@ -622,10 +626,10 @@
 						</options>
 					</constraints>
 					<control format="string" type="list">
-						<heading>32091</heading>
+						<heading>32065</heading>
 					</control>
 				</setting>
-				<setting help="32090" id="auto_eac3_ddp_atmos" label="32089" type="integer">
+				<setting help="" id="auto_dts" label="32066" type="integer">
 					<level>0</level>
 					<default>0</default>
 					<constraints>
@@ -645,10 +649,10 @@
 						</options>
 					</constraints>
 					<control format="string" type="list">
-						<heading>32089</heading>
+						<heading>32066</heading>
 					</control>
 				</setting>
-				<setting help="32094" id="auto_dca" label="32093" type="integer">
+				<setting help="" id="auto_dtshd" label="32067" type="integer">
 					<level>0</level>
 					<default>0</default>
 					<constraints>
@@ -668,10 +672,10 @@
 						</options>
 					</constraints>
 					<control format="string" type="list">
-						<heading>32093</heading>
+						<heading>32067</heading>
 					</control>
 				</setting>
-				<setting help="32088" id="auto_dtshd_hra" label="32087" type="integer">
+				<setting help="" id="auto_truehd" label="32068" type="integer">
 					<level>0</level>
 					<default>0</default>
 					<constraints>
@@ -691,147 +695,9 @@
 						</options>
 					</constraints>
 					<control format="string" type="list">
-						<heading>32087</heading>
+						<heading>32068</heading>
 					</control>
 				</setting>
-				<setting help="32086" id="auto_dtshd_ma" label="32085" type="integer">
-					<level>0</level>
-					<default>0</default>
-					<constraints>
-						<options>
-							<option label="32026">0</option>
-							<option label="32007">1</option>
-							<option label="32008">2</option>
-							<option label="32009">3</option>
-							<option label="32010">4</option>
-							<option label="32051">5</option>
-							<option label="32053">6</option>
-							<option label="32055">7</option>
-							<option label="32057">8</option>
-							<option label="32059">9</option>
-							<option label="32061">10</option>
-							<option label="32045">11</option>
-						</options>
-					</constraints>
-					<control format="string" type="list">
-						<heading>32085</heading>
-					</control>
-				</setting>
-				<setting help="32084" id="auto_truehd" label="32083" type="integer">
-					<level>0</level>
-					<default>0</default>
-					<constraints>
-						<options>
-							<option label="32026">0</option>
-							<option label="32007">1</option>
-							<option label="32008">2</option>
-							<option label="32009">3</option>
-							<option label="32010">4</option>
-							<option label="32051">5</option>
-							<option label="32053">6</option>
-							<option label="32055">7</option>
-							<option label="32057">8</option>
-							<option label="32059">9</option>
-							<option label="32061">10</option>
-							<option label="32045">11</option>
-						</options>
-					</constraints>
-					<control format="string" type="list">
-						<heading>32083</heading>
-					</control>
-				</setting>
-				<setting help="32082" id="auto_flac" label="32081" type="integer">
-					<level>0</level>
-					<default>0</default>
-					<constraints>
-						<options>
-							<option label="32026">0</option>
-							<option label="32007">1</option>
-							<option label="32008">2</option>
-							<option label="32009">3</option>
-							<option label="32010">4</option>
-							<option label="32051">5</option>
-							<option label="32053">6</option>
-							<option label="32055">7</option>
-							<option label="32057">8</option>
-							<option label="32059">9</option>
-							<option label="32061">10</option>
-							<option label="32045">11</option>
-						</options>
-					</constraints>
-					<control format="string" type="list">
-						<heading>32081</heading>
-					</control>
-				</setting>
-				<setting help="32080" id="auto_dtshd_ma_mx" label="32079" type="integer">
-					<level>0</level>
-					<default>0</default>
-					<constraints>
-						<options>
-							<option label="32026">0</option>
-							<option label="32007">1</option>
-							<option label="32008">2</option>
-							<option label="32009">3</option>
-							<option label="32010">4</option>
-							<option label="32051">5</option>
-							<option label="32053">6</option>
-							<option label="32055">7</option>
-							<option label="32057">8</option>
-							<option label="32059">9</option>
-							<option label="32061">10</option>
-							<option label="32045">11</option>
-						</options>
-					</constraints>
-					<control format="string" type="list">
-						<heading>32079</heading>
-					</control>
-				</setting>
-				<setting help="32078" id="auto_dtshd_ma_x_imax" label="32077" type="integer">
-					<level>0</level>
-					<default>0</default>
-					<constraints>
-						<options>
-							<option label="32026">0</option>
-							<option label="32007">1</option>
-							<option label="32008">2</option>
-							<option label="32009">3</option>
-							<option label="32010">4</option>
-							<option label="32051">5</option>
-							<option label="32053">6</option>
-							<option label="32055">7</option>
-							<option label="32057">8</option>
-							<option label="32059">9</option>
-							<option label="32061">10</option>
-							<option label="32045">11</option>
-						</options>
-					</constraints>
-					<control format="string" type="list">
-						<heading>32077</heading>
-					</control>
-				</setting>
-				<setting help="32076" id="auto_truehd_atmos" label="32075" type="integer">
-					<level>0</level>
-					<default>0</default>
-					<constraints>
-						<options>
-							<option label="32026">0</option>
-							<option label="32007">1</option>
-							<option label="32008">2</option>
-							<option label="32009">3</option>
-							<option label="32010">4</option>
-							<option label="32051">5</option>
-							<option label="32053">6</option>
-							<option label="32055">7</option>
-							<option label="32057">8</option>
-							<option label="32059">9</option>
-							<option label="32061">10</option>
-							<option label="32045">11</option>
-						</options>
-					</constraints>
-					<control format="string" type="list">
-						<heading>32075</heading>
-					</control>
-				</setting>
 				<setting help="" id="auto_othercodec" label="32069" type="integer">
 					<level>0</level>
 					<default>0</default>
@@ -856,9 +722,7 @@
 					</control>
 				</setting>
 			</group>
-		</category>
-		<category help="" id="channels" label="32049">
-			<group id="1">
+			<group id="2" label="32049">
 				<setting help="" id="auto_stereo" label="32071" type="integer">
 					<level>0</level>
 					<default>0</default>

@pkscout
Copy link
Member Author

pkscout commented Jan 10, 2026

It's been a week, so I'm merging this without review.

@pkscout pkscout merged commit a6cc463 into xbmc:piers Jan 10, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant