fix: SinsVR scraper crash guards and nil pointer fixes#2140
Open
mvdeckard wants to merge 1 commit intoxbapps:masterfrom
Open
fix: SinsVR scraper crash guards and nil pointer fixes#2140mvdeckard wants to merge 1 commit intoxbapps:masterfrom
mvdeckard wants to merge 1 commit intoxbapps:masterfrom
Conversation
- Add recover/defer to scene callback to prevent panics from crashing the app - Add bounds check on ChildAttrs before accessing dl8-video attributes - Fix nil pointer crash when http.Head fails in cast fallback (defer on nil response) - Close response body immediately instead of deferring inside loop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
recover/deferto the scene scraping callback to prevent any panic from crashing the entire application — the scraper logs the error and moves to the next scene insteadChildAttrsbefore accessingdl8-videoattributes (scene ID and title) to handle pages missing the video elementhttp.Headreturns an error — previouslydefer profileUrlResp.Body.Close()ran on a nil responseContext
Scenes like
https://xsinsvr.com/video/amateurhave an empty "Starring" section (no actors listed), which triggers the cast fallback code path. Ifhttp.Headfails for the model profile URL lookup, the nil response causes a panic that crashes the app. Therecoverwrapper provides a safety net against any future unexpected site changes as well.