ci: trigger for releases now allows changes in major version#756
Merged
ci: trigger for releases now allows changes in major version#756
Conversation
robhoes
approved these changes
Feb 19, 2026
psafont
force-pushed
the
dev/pau/2026
branch
from
2ed7f9d to
1cbc24d
Compare
lindig
reviewed
Feb 19, 2026
.github/workflows/release.yml
Outdated
| tags: | ||
| - '6.*' | ||
| # matches 0.0.0 through 99.99.99, allowing for suffixes | ||
| - '[0-9]?[0-9]+.[0-9]+[0-9]?.[0-9]+[0-9]?*' |
Collaborator
There was a problem hiding this comment.
According to Copilot this is a glob pattern and not a regexp - so it that does not support + according to that.
Collaborator
There was a problem hiding this comment.
You linked to the reference, so Copilot is wrong here.
Collaborator
There was a problem hiding this comment.
[0-9]+ should be enough to capture digits
Collaborator
There was a problem hiding this comment.
[0-9]+.[0-9]+.[0-9]+* imho is sufficient because * is a glob
Member
Author
There was a problem hiding this comment.
Ah, you're right, + shouldn't be used at all, I want only to allow 1 or 2 digits here. I've changed the match
lindig
approved these changes
Feb 19, 2026
The current pattern now is better at defining the shape of a release, it allows for some leeway at the end. Useful to add some string at the end, which is used when a patched release is made for XCP-ng. See https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#filter-pattern-cheat-sheet Signed-off-by: Pau Ruiz Safont <pau.safont@vates.tech>
psafont
force-pushed
the
dev/pau/2026
branch
from
1cbc24d to
cc45a94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current pattern now is better at defining the shape of a release, it allows for some leeway at the end. Useful to add some string at the end, which is used when a patched release is made for XCP-ng.
See
https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#filter-pattern-cheat-sheet