CA-423816 avoid double counting VM overhead memory#7005
Open
lindig wants to merge 2 commits intoxapi-project:masterfrom
Open
CA-423816 avoid double counting VM overhead memory#7005lindig wants to merge 2 commits intoxapi-project:masterfrom
lindig wants to merge 2 commits intoxapi-project:masterfrom
Conversation
When we are using a known memory configuration it includes the overhead. So we only have to add it when we create a new configuration. Localhost migration in a loop before and after the patch, memory reported by list_domains -memory -bytes: Before: id | uuid | state | tot bytes | max bytes | shadow bytes 17 | 8fc1ada1-... | B H | 4296003584 | 4336898048 | 36700160 18 | 8fc1ada1-... | B H | 4296003584 | 4376743936 | 36700160 19 | 8fc1ada1-... | B H | 4296003584 | 4416589824 | 36700160 20 | 8fc1ada1-... | B H | 4296003584 | 4456435712 | 36700160 21 | 8fc1ada1-... | B H | 4296003584 | 4496281600 | 36700160 22 | 8fc1ada1-... | B H | 4296003584 | 4536127488 | 36700160 23 | 8fc1ada1-... | B H | 4296003584 | 4575973376 | 36700160 24 | 8fc1ada1-... | B H | 4296003584 | 4615819264 | 36700160 25 | 8fc1ada1-... | B H | 4296003584 | 4655665152 | 36700160 26 | 8fc1ada1-... | B H | 4296003584 | 4695511040 | 36700160 After: id | uuid | state | tot bytes | max bytes | shadow bytes 27 | 8fc1ada1-... | B H | 4256157696 | 4297052160 | 36700160 28 | 8fc1ada1-... | B H | 4256157696 | 4297052160 | 36700160 29 | 8fc1ada1-... | B H | 4256157696 | 4297052160 | 36700160 30 | 8fc1ada1-... | B H | 4256157696 | 4297052160 | 36700160 31 | 8fc1ada1-... | B H | 4256157696 | 4297052160 | 36700160 32 | 8fc1ada1-... | B H | 4256157696 | 4297052160 | 36700160 33 | 8fc1ada1-... | B H | 4256157696 | 4297052160 | 36700160 34 | 8fc1ada1-... | B H | 4256157696 | 4297052160 | 36700160 35 | 8fc1ada1-... | B H | 4256157696 | 4297052160 | 36700160 36 | 8fc1ada1-... | B H | 4256157696 | 4297052160 | 36700160 Based on work by Edwin Torok. Signed-off-by: Christian Lindig <christian.lindig@citrix.com>
edwintorok
approved these changes
Apr 10, 2026
Member
edwintorok
left a comment
edwintorok
left a comment
There was a problem hiding this comment.
The output looks correct and stable.
You may want to drop the workaround from the quicktests now: https://github.com/xapi-project/xen-api/blob/0673787ff98121c85ea9fb66ae3d8894a5e8ea92/ocaml/quicktest/quicktest_vm_memory.ml#L15C27-L15C47 (there is a workaround_migration flag there that can be dropped completely)
Contributor
Author
|
How about using |
This fix in the previous patch should obsolete the workaround in the quickcheck. Signed-off-by: Christian Lindig <christian.lindig@citrix.com>
last-genius
approved these changes
Apr 10, 2026
Contributor
last-genius
left a comment
last-genius
left a comment
There was a problem hiding this comment.
Would you mind backporting this to 26.1-lcm?
Contributor
Author
|
I will pack port this after a merge. Just ran the updated quickest and it passed. |
Contributor
I don't think the quicktests themselves are backported |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we are using a known memory configuration it includes the overhead. So we only have to add it when we create a new configuration.
Localhost migration in a loop before and after the patch, memory reported by list_domains -memory -bytes:
Before:
After:
Based on work by Edwin Torok.