Fix local embedded database issues #172
Conversation
mutantmonkey
left a comment
mutantmonkey
left a comment
There was a problem hiding this comment.
Thanks for working on this. I think using the embedded DB by default in the docker-compose file is a good idea; I just want to make sure that the "sketchy" database initialization doesn't happen outside of dev environments.
| }) | ||
|
|
||
|
|
||
| #this command is sketchy, but it made running trackman locally work for me |
There was a problem hiding this comment.
I think it would be best to have this triggered by an environment variable...perhaps DB_INIT_ON_BOOT or something like that.
Also, for PEP8 compliance, please add a space between # and the rest of the comment. It might also be good to add some newlines to clearly separate the "sketchy" bit out, but I don't know that that's strictly necessary.
| environment: | ||
| - APP_CONFIG_PATH=/data/config/config.json | ||
| - USE_EMBEDDED_DB | ||
| - USE_EMBEDDED_DB=1 #DON'T USE FOR PRODUCTION |
There was a problem hiding this comment.
Please add a space between # and the rest of the comment to improve readability.
|
|
||
|
|
||
| @app.cli.command() | ||
| @app.cli.command('init_embedded_db') |
There was a problem hiding this comment.
I'm not sure this is necessary. It should use the function name by default, no?
There was a problem hiding this comment.
It didn't on my machine for some reason.
|
The more I think about this, the more I feel like the embedded database approach for development doesn't make much sense. If you're using it in the main container, it also needs to be enabled in the scheduler, but then you need to set up a shared volume between the containers, and at that point having the same Postgres database used in production running with docker-compose is easier so why even bother? |
3 participants
This pull request includes a few changes that I made while trying to get trackman to run on my local machine for testing purposes. After implementing these changes, in addition to adding a config.json file and a service_account file as well as creating an OAuth application within the WUVT domain, I was able to run a trackman instance on localhost.