feat: make rts less verbose, support 2 different rts for nfsboot#1019
feat: make rts less verbose, support 2 different rts for nfsboot#1019AlexKaravaev wants to merge 5 commits intomainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 21ec0dbc51
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e6e50e309d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 58d41f9fd2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0134d438b5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| /// S3 URI of a separate RTS whose `rts/` directory is used for `--mount` | ||
| /// content instead of the boot RTS. Use this when NFS-booting with a dev | ||
| /// build but flashing a stage or prod build. | ||
| #[arg(long, conflicts_with = "mount_rts_path")] |
There was a problem hiding this comment.
Adding --mount-s3-url introduces a new S3 download path, but this command still rejects --download-dir whenever --rts-path is present because rts_path keeps conflicts_with = "download_dir". In the new dual-RTS flow (--rts-path ... --mount-s3-url ...), users are forced to download the mount RTS into the current directory, which can fail in non-writable working directories and prevents directing artifacts to a controlled location.
Useful? React with 👍 / 👎.
1 participant
we need to support 2 rts for nfsboot if we want to test stage releases