Skip to content

made the constants consistently used instead of strings#624

Open
cg-cnu wants to merge 1 commit intowonderunit:masterfrom
cg-cnu:cleanup-const
Open

made the constants consistently used instead of strings#624
cg-cnu wants to merge 1 commit intowonderunit:masterfrom
cg-cnu:cleanup-const

Conversation

@cg-cnu
Copy link
Copy Markdown

@cg-cnu cg-cnu commented Sep 8, 2017

// TODO why even have these constants if we don't use them consistently?
const BRUSH_PENCIL = 'pencil'
const BRUSH_LIGHT_PENCIL = 'light-pencil'
const BRUSH_PEN = 'pen'
const BRUSH_BRUSH = 'brush'
const BRUSH_NOTE_PEN = 'note-pen'
const BRUSH_ERASER = 'eraser'

Fixed the issue noted in the todo. Replaced all stray strings in the file with respective constant 😄

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Oct 21, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants