made the constants consistently used instead of strings#624
Open
cg-cnu wants to merge 1 commit intowonderunit:masterfrom
cg-cnu:cleanup-const
Open
made the constants consistently used instead of strings#624cg-cnu wants to merge 1 commit intowonderunit:masterfrom cg-cnu:cleanup-const
cg-cnu wants to merge 1 commit intowonderunit:masterfrom
cg-cnu:cleanup-const
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
storyboarder/src/js/window/toolbar.js
Lines 10 to 17 in 0ae65ef
Fixed the issue noted in the todo. Replaced all stray strings in the file with respective constant 😄