Fix PEP 8: Remove unnecessary parentheses in conditionals#111
Draft
cursor[bot] wants to merge 1 commit intomainfrom
Draft
Fix PEP 8: Remove unnecessary parentheses in conditionals#111cursor[bot] wants to merge 1 commit intomainfrom
cursor[bot] wants to merge 1 commit intomainfrom
Conversation
- Remove unnecessary parentheses from if/elif conditions in utils.py and linkedin.py - Fix spacing around comparison operators (e.g., '>0' → '> 0') - Fix logic bug: Replace impossible condition 'type(len(resumes)) != int' with correct 'len(resumes) == 0' - Convert single-line if statement to proper multi-line format for readability - Improve code consistency and PEP 8 compliance Co-authored-by: Ongun Demirag <ongun@ongundemirag.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR improves code quality by removing unnecessary parentheses in conditional statements across the codebase, improving PEP 8 compliance and readability.
Files Modified
utils.py: Remove parentheses from 4 conditional statementslinkedin.py: Remove parentheses from 6 conditional statements + fix logic bugKey Improvements
PEP 8 Compliance: Removed unnecessary parentheses from all if/elif conditions
if(config.headless):→if config.headless:if(len(...) > 0):→if len(...) > 0:Spacing: Fixed operator spacing
>0→> 0Logic Bug Fix: Fixed impossible condition in resume selection
type(len(resumes)) != int(always False) →len(resumes) == 0Code Formatting: Converted single-line if statement to proper multi-line format for better readability
Impact