Fix impossible condition in chooseResume method#109
Draft
cursor[bot] wants to merge 1 commit intomainfrom
Draft
Conversation
Replace 'type(len(resumes)) != int' with 'len(resumes) == 0' to enable proper error messaging when no PDF resumes are found. The original condition was always False since len() always returns an int. Co-authored-by: Ongun Demirag <ongun@ongundemirag.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: The condition
type(len(resumes)) != inton line 311 of linkedin.py is always False sincelen()always returns an int in Python. This prevented the error message about missing resumes from ever being displayed.Fix: Replace the impossible condition with
len(resumes) == 0to properly detect when no PDF resumes are found and display the appropriate error message to users.Impact: Improves error handling and user feedback when resume selection fails.