Open
Conversation
On modern macOS (13+), NanoGUI's file_dialog() using NSOpenPanel/NSSavePanel fails silently because runModal returns immediately when called within GLFW's event loop. The file picker never appears. Replace with an osascript-based implementation that spawns a native macOS file dialog in a separate process, bypassing the GLFW event loop conflict. The fix is guarded with #ifdef __APPLE__ so Linux and Windows builds remain unchanged. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
file_dialog()callsNSOpenPanel.runModalwhich returns immediately withNSModalResponseCancelwhen invoked within GLFW's event looposascript-based native file dialog that runs in a separate process, bypassing the GLFW event loop conflict#ifdef __APPLE__— Linux and Windows builds are unaffectedChanged files
src/native_file_dialog.hnative_file_dialog()src/native_file_dialog.cpposascript/ AppleScriptchoose filesrc/viewer.cppfile_dialogcalls throughim_file_dialogmacroCMakeLists.txtTest plan
🤖 Generated with Claude Code