chore: update @withstudiocms/buildkit to version 0.1.0-beta.4 and remove test-scripts package#36
Merged
Adammatthiesen merged 3 commits intomainfrom Aug 26, 2025
Merged
Conversation
…ove test-scripts package
🦋 Changeset detectedLatest commit: 58e63b0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
📝 WalkthroughWalkthroughRemoves the internal test-scripts package and tooling references, updates root dev dependencies (switching to BuildKit), adjusts ignore/config settings, adds a changeset, and updates the web-vitals package test script to use BuildKit. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Dev as Developer
participant NPM as npm/yarn
participant PKG as packages/web-vitals
participant BK as BuildKit (CLI)
Dev->>NPM: run "npm test" in web-vitals
NPM->>PKG: execute scripts.test
Note over PKG: Updated command
PKG->>BK: buildkit test --timeout 50000 "test/**/*.test.js"
BK-->>Dev: Test results (spec output, exit code)
sequenceDiagram
autonumber
participant Dev as Developer
participant NPM as npm/yarn
participant PKG as packages/web-vitals
participant TS as test-scripts (removed)
participant Node as node:test
rect rgba(240,240,255,0.6)
Note over TS,Node: Previous flow (removed)
Dev->>NPM: npm test
NPM->>PKG: scripts.test
PKG->>TS: test-scripts test ...
TS->>Node: Orchestrate node:test, reporters, teardown
Node-->>Dev: Results
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
commit: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.changeset/little-trees-heal.md (1)
1-5: Clarify the changeset summary with specifics (tool version + package removal).Calling out the exact BuildKit version and the removal of the test-scripts package will make the changelog more actionable for consumers skimming releases.
Proposed tweak:
--- "@studiocms/web-vitals": patch --- -Updated buildkit and test scripts +Update BuildKit to 0.1.0-beta.4 and migrate tests from internal test-scripts to BuildKitpackages/web-vitals/package.json (1)
49-52: Test runner migration validated; BuildKit flags and glob behavior confirmedAll checks look good:
- BuildKit v0.1.0-beta.4 supports the
testcommand with--timeout(interpreted in milliseconds) and handles quoted glob patterns internally.- The workspace’s root
package.jsonalready pins"@withstudiocms/buildkit": "0.1.0-beta.4", butpackages/web-vitals/package.jsondoes not list it. If you ever run this package outside the monorepo, consider adding it locally to ensure the binary is always resolvable.Optional refactor (only if self-containment is desired):
--- a/packages/web-vitals/package.json +++ b/packages/web-vitals/package.json @@ "devDependencies": { + "@withstudiocms/buildkit": "0.1.0-beta.4",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (9)
.changeset/config.json(1 hunks).changeset/little-trees-heal.md(1 hunks)knip.config.ts(0 hunks)package.json(1 hunks)packages/test-scripts/cmd/test.js(0 hunks)packages/test-scripts/index.js(0 hunks)packages/test-scripts/jsconfig.json(0 hunks)packages/test-scripts/package.json(0 hunks)packages/web-vitals/package.json(1 hunks)
💤 Files with no reviewable changes (5)
- packages/test-scripts/jsconfig.json
- knip.config.ts
- packages/test-scripts/package.json
- packages/test-scripts/cmd/test.js
- packages/test-scripts/index.js
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-07-20T05:47:47.058Z
Learnt from: Adammatthiesen
PR: withstudiocms/web-vitals#8
File: packages/web-vitals/package.json:24-43
Timestamp: 2025-07-20T05:47:47.058Z
Learning: When reviewing package.json exports fields, check for build scripts that generate dist/ artifacts. It's normal for packages to reference build-generated files in exports that aren't committed to the repository, as they're created during the build/publish process.
Applied to files:
package.json
🔇 Additional comments (2)
.changeset/config.json (1)
10-10: LGTM: ignore list updated correctly after removing test-scripts.Removing "test-scripts" from the ignore array is consistent with the package deletion. No other config adjustments needed.
package.json (1)
24-34: All internal runner references removed and BuildKit updated consistently
- No occurrences of
test-scriptsremain anywhere in the repo.- No npm/yarn/pnpm scripts invoke
test-scripts.- Only one version of
@withstudiocms/buildkit(0.1.0-beta.4) is referenced inpackage.json.- CI workflows under
.github/contain no stale test-runner calls.
louisescher
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes the custom
test-scriptspackage and migrates test running in theweb-vitalspackage to use thebuildkittest command instead. It also updates the@withstudiocms/buildkitdependency to a newer version and cleans up related dependencies and configuration files.Migration to buildkit for testing:
web-vitalspackage now usesbuildkit testinstead of the customtest-scriptscommand to run tests, simplifying the test workflow.test-scriptspackage is removed, including its source files, configuration, and dependencies. [1] [2] [3] [4] [5]Dependency and lockfile updates:
@withstudiocms/buildkitfrom0.1.0-beta.1to0.1.0-beta.4in bothpackage.jsonandpnpm-lock.yaml, and updates its dependencies accordingly. [1] [2] [3] [4]test-scriptspackage from the monorepo lockfile. [1] [2]Minor lockfile cleanup:
cpufield from thelibsqldependency in the lockfile.Summary by CodeRabbit
Chores
Tests
Note