Conversation
|
WalkthroughThe peer dependency version specification for "@astrojs/db" in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
commit: |
There was a problem hiding this comment.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
packages/web-vitals/package.json (1)
4-4: Consider a major version bump for this packageRaising the minimum supported peer version can be a breaking change for consumers pinned to 0.16.x. Recommend bumping @studiocms/web-vitals to 5.0.0 (or include a Changeset marking a major).
- "version": "4.3.0", + "version": "5.0.0",
🧹 Nitpick comments (1)
packages/web-vitals/package.json (1)
57-57: Docs/update noteIf README or docs mention required Astro DB version, update to reflect the new minimum (>=0.17).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/web-vitals/package.json(1 hunks)
🔇 Additional comments (2)
packages/web-vitals/package.json (2)
57-57: Peer dep bump LGTMRaising the floor to @astrojs/db ^0.17.0 matches the PR intent. No issues with the range (>=0.17.0 <0.18.0).
60-63: Confirm pnpm catalog maps to ^0.17.xdevDependencies use "catalog:"; make sure the root pnpm.catalog sets "@astrojs/db": "^0.17.0" so local dev/tests resolve to the intended version.
Fixes peer dep issue for the release
Summary by CodeRabbit