Conversation
🦋 Changeset detectedLatest commit: 823b057 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hello! Thank you for opening your first PR to Starlight! ✨ Here’s what will happen next:
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
trueberryless
left a comment
There was a problem hiding this comment.
Thank you for your amazing first contribution to Starlight 🥳
I really like your changes and I am mostly happy with them. I just left two small comments regarding documentation and the changelog.
One more general thing however: It seems that in the discussion about this feature, people expected the icon to replace the right arrow, so I wonder if two icons would be too confusing. One idea would be to replace the right arrow when iconPlacement is set to "end", however I assume this would feel unintuitive and inconsistent to the user.
Maybe we should further discuss this in the discussion until a clear path for the feature is decided. Nonetheless, this seems like a decently upvoted discussion, so thank you for getting the ball rolling on this feature 🚀
I also am not a maintainer, and therefore, I don't know if they want that such a feature waits until we support custom icons. But from my side, this feature is not affected by custom icons. 👍
Co-authored-by: Felix Schneider <[email protected]>
Co-authored-by: Felix Schneider <[email protected]>
|
Thanks for the feedback! I've applied the suggested changes to the docs and changeset. Regarding the icon/arrow coexistence, I've started a quick follow-up in the original discussion #970 (comment) to see what the community prefers. I'll update the PR once we have a clearer path! |

Description
This PR implements the long-awaited
iconsupport for theLinkCardcomponent, as discussed in #970.Currently, users have to duplicate the
LinkCardsource code locally to add icons. This PR provides a first-class, type-safe implementation that maintains consistency with the standardCardcomponent.Changes
iconandiconPlacementprops toLinkCard.astro.StarlightIconfor full type safety.test-d.tsto ensure parity.Relates to