Addition of Logger.getAll() method as discussed in #970 #2515
Open
prkbuilds wants to merge 4 commits intowinstonjs:masterfrom
Open
Addition of Logger.getAll() method as discussed in #970 #2515prkbuilds wants to merge 4 commits intowinstonjs:masterfrom
prkbuilds wants to merge 4 commits intowinstonjs:masterfrom
Conversation
DABH
approved these changes
Oct 14, 2024
Contributor
DABH
left a comment
DABH
left a comment
There was a problem hiding this comment.
LGTM up to a couple formatting/nits
Contributor
|
@PratikFandade Can you please also add at least one simple test for this new function, so that coverage doesn't decrease? Thanks! |
Author
|
Hey @DABH ! So sorry for being away and thanks for the change on formatting. I will start working on a test for this and update the PR so the coverage is there for this functionality. |
Author
|
I've added some unit test coverage for this new functionality as discussed, let me know if you know if this can be improved further! |
Author
|
Hi @DABH, please let me know if there are any other changes you'd like me to make to this PR. If everything looks good, we can go ahead and close the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue : #970
As discussed in issue #970, this PR introduces a new method that returns a Map. This enhancement allows users to retrieve all loggers that match a given regex pattern, providing a convenient way to manage and configure multiple loggers at once.
With this new functionality, users can now establish mass control over their loggers by iterating over the returned Map, making bulk configuration and modifications simpler and more efficient. This change is aimed at improving flexibility and easing the management of logger configurations in large-scale applications.
@DABH PR for the changes I thought about, let me know if you are looking for a different approach for this feature.