Add ability to drain redis queue before closing logger, update Redis client library version#22
Open
thecubed wants to merge 1 commit intowinstonjs:masterfrom
Open
Add ability to drain redis queue before closing logger, update Redis client library version#22thecubed wants to merge 1 commit intowinstonjs:masterfrom
thecubed wants to merge 1 commit intowinstonjs:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
What happens if the drain event is never emitted?
Author
|
I believe if the 'drain' event isn't emitted by the Redis library that the logger will hang until Redis's queue is empty. This would prevent messages from being dropped that were queued when the log.close() method is called. I can check and see if there's a way to have Winston pass a value along to us that allows for force closing the connection by default or to wait for the drain event and close gracefully if set. |
Contributor
|
@thecubed I think that would be preferable, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.