Open
Conversation
* - adds navigation arch * - simplify navigation
* - adds ExploreFeedUpdatePromptActivity - adds strings for ExploreFeedUpdatePromptActivity - adds preference for controlling ExploreFeedUpdatePromptActivity access - adds icon resources * - open explore feed update prompt from feed fragment - code fixes * - code fixes
* Explore Feed: Onboarding: Intro Screens and Context Setting * Integrate with the initialOnboardingActivity * Almost * Optimize * Code review comments * Update asset, function and handle navigation bar correctly
…ps-android-wikipedia into explore-feed-upgrade-design
* NewExploreFeed: the Feed building screen * Update asset and ready for design signoff
* NewExploreFeed: Languages pick screen * Callbacks * Finishing up * Language pick * Add language selection to initialOnboarding screen * Fix * Update content description
* Allow edge-to-edge for MainActivity, enabling full-bleed compositions. * Remove redundant name. * Initial exploration of HomeFragment. * Yes. * Remember snap fling state. * Yep. * Bunch of hacks for applying non-default theme colors to NavBar. * Imports. * Explicitly set LightSystemUiVisibility. * Framework for Home fragment in Compose. * Properly account for status bar inset. * Refactor a bit. * Further solidify. * Break out ViewModel. * Review comments. * Remove annotation. * Apply different themes when switching tabs, and fill out some more. * OK... * Wire up. * Alright... * Alright!
* NewExploreFeed: rename "Explore" to "Home" * update for strings that may not be used later * add qq strings * Code review comments * Fix merge issue * Fix reference
* Community Picks: Top Read Module * Better paddings * wire to home * Clickable area: * click behavior * Adding trending up/down icons * Update token * Finalized * Pull to refresh * show localized name in the description * Remove language text
* Home feed: Picture of the Day module. * Make image clickable. * Wire up downloading image. * Solidify. * Properly wire up refresh box. * Factor out module header. * Whoops. * Fine, make modifier be the first parameter. * Add missing wiring. * Make icon buttons be 48dp. * Use proper contentDescription. * Whoops. --------- Co-authored-by: Cooltey Feng <cfeng@wikimedia.org>
* Home feed: Picture of the Day module. * Make image clickable. * Wire up downloading image. * Solidify. * Properly wire up refresh box. * Factor out module header. * Whoops. * Fine, make modifier be the first parameter. * Flesh out featured article. * Add missing wiring. * Deduplicate. --------- Co-authored-by: Cooltey Feng <cfeng@wikimedia.org>
* NewExploreFeed: design tweak for onboarding screens * Fixed thumb height and resolve jumpling
* - adds PersonalizationScreen.kt - adds interest onboarding related screens - adds string resources * - adds raw state for PersonalizationScreen to derive interest ui states - adds state models - adds viewModel and interest placeholder screen * - adds click event on category and adds comments * - adds personalization screen as activity - code fixes * - adds navigation * - adds more UI for interest selection and business logic - code fixes * - adds shimmer effect * - adds onboarding topics data and message api call * - adds bottom selection bar - moves view to its own composable functions - adds string resource - code fixes * - dose not replace selected articles * - adds proper api call to getArticlesByTopic - adds topics - code fixes * - updates interest screen ui to be fully scrollable * - adds interest entity, dao, and viewmodel logic - code fixes * - converts selectedTopics to list of onboarding for readability and access * - adds preview * - adds namespace to Interest entity - adds deleteAllByType query - adds viewModelFactory to PersonalizationViewModel.kt - code fixes and cleanups * - rename and moves re-usable interest selection components to compose/components * fix lint * - code fixes * - renames articleTopics to queryTopicId * - splits Interest.kt into ArticleInterest.kt and TopicInterest.kt - writes DAO for article and topic interest - update PersonalizationViewModel.kt and PersonalizationRepository.kt - updates SelectionBottomBar to use count of both article and topics - code fixes * - maps one to many relationship between article and topic interest - adds job in PersonalizationViewModel.kt - code fixes * - adds code to restore persisted interest for returning user - update article and topic interest dao - code fixes * - adds showError - code fixes * - code fixes - updates db entities and adds unit test * - adds new db structure json file * - fix migration * - fix db unit test * - code/ui fixes - renames article and topic interest table * - moves personalization to feed package, separate interest into its own package * - rename repository to interestSelectionRepository * - only show ExploreFeedUpdatePromptActivity for existing users --------- Co-authored-by: Cooltey Feng <cfeng@wikimedia.org>
* NewExploreFeed: In the news module * Add to the feed * Fix import * Finish the implementation
* NewExploreFeed: Feed Layout & Framework * Language Code box * Wire up language picker to home feed. * Minor adjustment * Better clickable * Fix lint * Update module order * show text based on the selected language * Add preference for selected language * Untangle viewModel from HomeScreen composable. --------- Co-authored-by: Dmitry Brant <me@dmitrybrant.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phabricator:
https://phabricator.wikimedia.org/T407990