[WV-2296]queryset_find_candidates_to_link_to_this_politician inefficient query queryset[Team Review]#3057
Open
pravingv wants to merge 12 commits intowevote:developfrom
Open
[WV-2296]queryset_find_candidates_to_link_to_this_politician inefficient query queryset[Team Review]#3057pravingv wants to merge 12 commits intowevote:developfrom
queryset_find_candidates_to_link_to_this_politician inefficient query queryset[Team Review]#3057pravingv wants to merge 12 commits intowevote:developfrom
Conversation
mjacquot1
reviewed
Apr 6, 2026
| politician_url5 = request.GET.get('politician_url5', False) | ||
| political_party = request.GET.get('political_party', False) | ||
| state_code = request.GET.get('state_code', False) | ||
| use_trigram_match = positive_value_exists(request.GET.get('use_trigram_match', False)) |
Contributor
There was a problem hiding this comment.
This is a nitpick, but I would recommend:
trigram_match = request.GET.get('use_trigram_match', False)
and later on use_trigram_match = positive_value_exists(trigram_match)
This is just to keep logic blocks consistent since the rest of them are request.GET.get() clustered
Contributor
|
Seems good overall! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What github.com/wevote server/issues does this fix
WV-2296 'queryset_find_candidates_to_link_to_this_politician` inefficient query queryset
Changes included this pull request?
politician/controllers.pyAdded trigram-based query support to improve SQL query performance. If trigram indexes are unavailable, the original query is used as a fallback so results are still returned.
politician/enums.py politician/views_admin.pyAdded a new enum, RET_CANDIDATES_MATCH, with the label "Find possible Candidate duplicates of this politician". This helps separate speed statistics for duplicate-politician queries from candidate-match queries for a politician.
**Note: **This PR should be reviewed and executed together with the following PRs:
#3055
— Needed to show trigram vs. non-trigram search results.
#3054
— Generates the required trigram indexes for improved SQL query performance.