Skip to content

fix(ops-suite): enforce adapter pattern, fix auto-chain, add consumer-patterns reference#6

Open
aldorea wants to merge 1 commit intomainfrom
fix/ops-suite-skill-quality
Open

fix(ops-suite): enforce adapter pattern, fix auto-chain, add consumer-patterns reference#6
aldorea wants to merge 1 commit intomainfrom
fix/ops-suite-skill-quality

Conversation

@aldorea
Copy link
Copy Markdown
Collaborator

@aldorea aldorea commented Apr 21, 2026

Summary

  • Adapter pattern enforcement: db-query y db-migrate tenían comandos kubectl port-forward hardcodeados en el cuerpo de la skill. Ahora delegan al adapter del orchestrator (port-forward/adapters/{orchestrator}.md), lo que hace que las skills funcionen correctamente con Docker Compose y ECS, no solo Kubernetes.
  • port-forward/kubernetes.md: nueva sección Retrieve environment variable from a running pod separada de Retrieve secret (K8s Secret vs env var de pod son mecanismos distintos).
  • queue-status auto-chain eliminado: queue-status invocaba queue-triage automáticamente al detectar DLQ con mensajes, desencadenando un análisis Sonnet completo sin confirmación del usuario. Cambiado a sugerencia via Next steps.
  • queue-triage Step 6 genérico: eliminadas referencias hardcodeadas a NestJS (application/amqp/, onApplicationBootstrap(), subscribe()). Reemplazado con grep genérico + puntero a nuevo references/consumer-patterns.md.
  • consumer-patterns.md (nuevo): patrones de búsqueda por framework (NestJS + @golevelup/nestjs-rabbitmq, Spring AMQP, Celery), cargados on-demand.
  • workflow-deploy path fix: ruta ../deploy/adapters/ reemplazada por ${CLAUDE_PLUGIN_ROOT}/skills/deploy/adapters/ — ya no se rompe si la skill deploy cambia de ubicación relativa.
  • CLAUDE.md: guía de proyecto para futuras instancias de Claude Code.

Test plan

  • Verificar que db-query en un entorno ECS o Docker Compose carga el adapter correcto sin intentar kubectl
  • Verificar que db-migrate en Kubernetes resuelve credenciales via el nuevo section del adapter
  • Verificar que queue-status muestra Next steps en lugar de auto-invocar queue-triage
  • Verificar que queue-triage Step 6 funciona con un codebase no-NestJS
  • Verificar que workflow-deploy carga el CI adapter correctamente con ${CLAUDE_PLUGIN_ROOT}

🤖 Generated with Claude Code

… add CLAUDE.md

- db-query/db-migrate: replace hardcoded kubectl port-forward with reference to
  port-forward adapter, so non-Kubernetes orchestrators work correctly
- port-forward/adapters/kubernetes.md: add separate section for pod env var
  retrieval (pod_env pattern) vs Kubernetes Secret retrieval
- queue-status: change DLQ auto-chain to queue-triage into a suggest (Next steps),
  preventing unintended Sonnet invocations on a simple status check
- queue-triage: remove NestJS-specific patterns from Step 6, replace with generic
  grep approach + reference to new consumer-patterns.md loaded on-demand
- queue-triage/references/consumer-patterns.md: new file with framework-specific
  consumer search patterns (NestJS, Spring AMQP, Celery)
- workflow-deploy: fix cross-skill adapter path from relative ../deploy/ to
  ${CLAUDE_PLUGIN_ROOT}/skills/deploy/ to avoid path fragility
- CLAUDE.md: add project-level guidance for future Claude Code instances

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@aldorea aldorea self-assigned this Apr 21, 2026
@aldorea aldorea added the enhancement New feature or request label Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant