Skip to content

fix: use resizable image MIME types in Accept header for external image fetch #5599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kyrisu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use resizable image MIME types in Accept header for external image fetch #5599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/builder/app/routes/rest.assets_.$name.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import type { ActionFunctionArgs } from "@remix-run/server-runtime";
import { uploadFile } from "@webstudio-is/asset-uploader/index.server";
import {
isAllowedMimeCategory,
IMAGE_MIME_TYPES,
RESIZABLE_IMAGE_MIME_TYPES,
ALLOWED_FILE_TYPES,
} from "@webstudio-is/sdk";
import type { AssetActionResponse } from "~/builder/shared/assets";
Expand Down Expand Up @@ -50,7 +50,7 @@ export const action = async (
const imageRequest = await fetch(url, {
method: "GET",
headers: {
Accept: IMAGE_MIME_TYPES.join(","),
Accept: RESIZABLE_IMAGE_MIME_TYPES.join(","),
},
});

Expand Down
16 changes: 16 additions & 0 deletions packages/sdk/src/assets.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,22 @@ export const IMAGE_MIME_TYPES: readonly string[] = IMAGE_EXTENSIONS.map(
(ext) => ALLOWED_FILE_TYPES[ext as keyof typeof ALLOWED_FILE_TYPES]
);

/**
* Subset of IMAGE_MIME_TYPES supported as input by the image resizing pipeline.
* Used in the Accept header when fetching external images to prevent services
* like Unsplash (with auto=format) from serving formats like AVIF that cause
* Cloudflare Image Resizing ERROR 9520 during transformation.
*
* See: https://developers.cloudflare.com/images/transform-images/#supported-input-formats
*/
export const RESIZABLE_IMAGE_MIME_TYPES: readonly string[] = [
"image/jpeg",
"image/png",
"image/gif",
"image/webp",
"image/svg+xml",
];

/**
* All video file extensions
*/
Expand Down
Loading