fix: update the message on mode selection dropdown.#4881
Open
victorchrollo14 wants to merge 3 commits intowebstudio-is:mainfrom
Open
fix: update the message on mode selection dropdown.#4881victorchrollo14 wants to merge 3 commits intowebstudio-is:mainfrom
victorchrollo14 wants to merge 3 commits intowebstudio-is:mainfrom
Conversation
kof
reviewed
Feb 16, 2025
Member
|
Seems like no reason to show select at all in such situation? |
Member
agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
fixes issue #4626
added a function that returns the default message after checking what all modes are enabled, if both the content mode and design mode is enabled then we display "Select Design or Content mode", if content mode is disabled then we display "Select Design mode" ie in the share page where links generated by free users has the content mode disabled.
but the function doesn't handle a case where both the content and design mode are disabled, since there didn't seem to be any scenario where both are disabled. in such a scenario we should probably just hide the drop down menu that let users select content or design mode.
Steps for reproduction
Code Review
Before requesting a review
Before merging
.envfile