Run pytest directly. setup.py test was removed in setuptools 72.#172
Merged
wumpus merged 2 commits intowebrecorder:masterfrom Aug 21, 2024
Merged
Conversation
This was referenced Aug 19, 2024
Merged
Collaborator
|
Hm. Code coverage is not currently working, which makes it difficult to properly test this PR. |
Contributor
Author
|
There is coverage output in the logs: https://github.com/webrecorder/warcio/actions/runs/10406578911/job/28991147343?pr=172#step:7:337 |
Contributor
Author
|
On master it is currently: https://github.com/webrecorder/warcio/actions/runs/10468183347/job/28988504338#step:6:364 |
Contributor
Author
|
The only difference is: While I don't get the value for faster, since the new test for version was introduced in 29da916. The coverage stays the same resp. has increased for |
Collaborator
|
Thank you, perfect, I should have looked more carefully at the logs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run pytest directly. setup.py test was removed in setuptools 72.
https://setuptools.pypa.io/en/latest/history.html#v72-0-0
Derived from #169 . Lets split it into portions.