frame behaviors: use frame.evaluate() instead of custom evaluteWithCLI()

[ikreymer]

Removes our custom evaluateWithCLI() call in favor of using standard frame.evaluate().
The custom method became more tricky to use, and doesn't work for all iframes.
The main benefit of it was to inject getEventListeners(), which is now only used in Autoscroll to potentially skip scrolling, and not needed for any other behaviors.

We could potentially use this workaround: https://stackoverflow.com/questions/75517220/geteventlistener-function-support-for-latest-puppeteer-versions/75581410#75581410 to bring back getEventListeners or, adding a custom callback, like hasEventListener() would suffice for that check.

This simplifies the codebase and ensures that running behaviors is more reliable.
Also, adds a callback for new frames that may get added to page, such as during scrolling, an ensures behaviors are called on those iframes as well.

[tw4l]

Tested with autoscroll and https://raw.githubusercontent.com/webrecorder/custom-behaviors/refs/heads/main/behaviors/timeline.js. I can see log messages indicating that behavior scripts are run and finished, but the actual behaviors themselves don't seem to happen - in the screencast I don't see any scrolling happening on pages where it should, and for the custom behavior I don't see the behavior running in the screenshare or any log lines from the custom behavior as expected.

[ikreymer]

Tested with autoscroll and https://raw.githubusercontent.com/webrecorder/custom-behaviors/refs/heads/main/behaviors/timeline.js. I can see log messages indicating that behavior scripts are run and finished, but the actual behaviors themselves don't seem to happen - in the screencast I don't see any scrolling happening on pages where it should, and for the custom behavior I don't see the behavior running in the screenshare or any log lines from the custom behavior as expected.

Good catch, fixed, removing unnecessary function wrapping which didn't actually await the promise..

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	browsertrix-behaviors@​0.9.7 ⏵ 0.9.8			+1	-3

View full report

[tw4l]

Re-tested and working now, thanks!