fix(a11y): fixed background contrast in Lighthouse and removed underline #8114
Open
pranjalisr wants to merge 1 commit intowebpack:mainfrom
Open
fix(a11y): fixed background contrast in Lighthouse and removed underline #8114pranjalisr wants to merge 1 commit intowebpack:mainfrom
pranjalisr wants to merge 1 commit intowebpack:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
|
/cc @evenstensberg please take a look too |
| > | ||
| {link.children.map((child) => { | ||
| const classNames = | ||
| "text-blue-400 dark:text-[#69a8ee] py-5 text-sm capitalize hover:text-black dark:hover:text-white"; |
Member
There was a problem hiding this comment.
i think this set set using our design palettes
Contributor
Author
There was a problem hiding this comment.
I am a bit confused, should i use main(original) colors for text or are you suggesting something else?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces #8103
Removed unnecessary underline from everywhere in main website and fixed Background and foreground colors do not have sufficient contrast ratio under Contrast issue in Lighthouse
What kind of change does this PR introduce?
Code changes
Did you add tests for your changes?
No
Does this PR introduce a breaking change?
No
If relevant, what needs to be documented once your changes are merged or what have you already documented?
N/A
Use of AI
No