Skip to content

refactor!: remove node-fetch; require Node.js >=20#505

Merged
christian-bromann merged 1 commit intowebdriverio-community:mainfrom
YasharF:fetch
Aug 10, 2025
Merged

refactor!: remove node-fetch; require Node.js >=20#505
christian-bromann merged 1 commit intowebdriverio-community:mainfrom
YasharF:fetch

Conversation

@YasharF
Copy link
Copy Markdown
Contributor

@YasharF YasharF commented Aug 10, 2025

BREAKING CHANGE: Node.js 20 or higher is now required. Node.js 18 reached end-of-life in April 2025.

Replace node-fetch with the built-in fetch API available in Node.js 20+. This is a part of the fix for the deprecation warnings related to node-domexception. node-fetch hasn't seen much active development lately, and the built-in fetch API makes it largely redundant.

BREAKING CHANGE: Node.js 20 or higher is now required. Node.js 18 reached end-of-life in April 2025.

Replace node-fetch with the built-in fetch API available in Node.js 20+. This reduces bundle size and avoids deprecation warnings related to node-domexception. node-fetch hasn't seen much active development lately, and the built-in fetch API makes it largely redundant.
@YasharF
Copy link
Copy Markdown
Contributor Author

YasharF commented Aug 10, 2025

Verifications completed:

Local:

  • rm -rf node_modules
  • npm install
  • npm run build
  • npm run test

Github Actions runs:

Copy link
Copy Markdown
Contributor

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann merged commit 83abae8 into webdriverio-community:main Aug 10, 2025
5 checks passed
@YasharF YasharF deleted the fetch branch August 12, 2025 00:12
@Brooooooklyn
Copy link
Copy Markdown

Can we publish this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants