Draft
Conversation
8be5c46 to
4c63e79
Compare
Thanks to @Jym77 for the reproduction: https://github.com/Jym77/web-features-ts-esm Co-authored-by: Jean-Yves Moyen <19969498+Jym77@users.noreply.github.com>
4c63e79 to
5b2dc4e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two issues with the types we use in web-features:
web-features's typesFixes #1980. See also Jym77/web-features-ts-esm, which was essential for fixing these issues.
If you want to try this version of the package, check out this branch and follow steps along these lines.