Symlinks not resolved in get_main_dir(), preferences.plist not found when symlinked.

[joraff]

Hi Greg,

When someone installs reposado to, say, /usr/local/reposado then symlinks repo_sync and repoutil from /usr/bin, reposadocommon.py's get_main_dir() doesn't resolve that symlink and looks for preferences.plist in /usr/bin.

I would rather keep everything together and have my preferences.plist file in /usr/local/reposado/code, and only have the two symlinks in /usr/bin.

Easy fix, but it will likely break the configuration for existing reposado installs. I added some ugly logic that will give a preferences.plist file at the unresolved location precedence over one at the resolved path.

[gregneagle]

I won't merge this as-is because it could break existing installs. If you changed the logic to something like:

def prefsFilePath():
paths = [os.path.join(get_main_dir(), 'preferences.plist'), os.path.realpath(get_main_dir(True)), 'preferences.plist')]
for a_path in paths:
if os.path.exists(a_path):
return path
return paths[0]

So it would still default to the same location as before, but use the directory of the target of the symlink if it existed, I'd feel better about accepting this.

Or bring it up for discussion on the reposado list.

[joraff]

Greg, that's almost exactly what 1d5d27a addresses, albeit in a different way. I didn't mean to include the 1e8a4aa commit.

You'd still need a join on the second paths object, os.path.realpath(get_main_dir(True)), but I do like your logic better. I tend to use try's and opens to avoid race conditions, but that shouldn't be an issue here.

[n8felton]

@joraff Is this something you'd be willing to clean up the code to address Greg's concerns and also allow for it to be merged without conflicts? I'm interested in having this issue fixed as I currently have repo_sync and repoutil symlinked to /usr/local/bin