Merged
Conversation
Shared converters in proto/decoders.rs for Contract, Order, OrderState, Execution, ContractDetails, and other reusable types. Domain-specific decoders in each module decoders.rs with _proto suffix. Unit tests construct protobuf bytes with prost and verify decoded domain structs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
proto/decoders.rs(Contract, Order, OrderState, Execution, ContractDetails, and other reusable types) withpub(crate)helpers (parse_f64,optional_f64,tag_values,ts, etc.)orders,contracts,market_data/realtime,market_data/historical,accounts,news,scanner,display_groups,wsh) with_protosuffixError::ProtobufDecode(#[from] prost::DecodeError)variant — eliminatesmap_errboilerplate across all decodersperm_idpromoted fromi32toi64inOrder,Execution, andOrderStatusTest plan
cargo clippy --all-targets -- -D warningscargo clippy --all-targets --features sync -- -D warningscargo clippy --all-featurescargo fmt --checkcargo test(all tests pass, 36 new proto decoder + error tests)