Fix operand order in v128_select_ssss#1834
Open
shumbo wants to merge 1 commit intowasmi-labs:mainfrom
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1834 +/- ##
=======================================
Coverage 73.37% 73.37%
=======================================
Files 175 175
Lines 14274 14274
=======================================
Hits 10473 10473
Misses 3801 3801 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@shumbo thank you a lot for the bug fix and especially for the additional regression test! |
Member
|
The audit CI job is failing for reasons not associated to this PR's changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a miscompilation in SIMD
v128.select.v128_select_ssssis executed with operands in the order(result, condition, true_val, false_val), but the translator currently emits(result, condition, false_val, true_val)when loweringv128.select. This causes the instruction to select the opposite branch.Other select variants, including
u32_select_*andu64_select_*, already use the correct operand order, so the issue is specific to thev128lowering path.Regression test:
The test passes with this patch.