Conversation
There was a problem hiding this comment.
Pull request overview
This PR revamps the WASIX test infrastructure by introducing a new test utility framework and comprehensive context switching tests. The changes replace the old inline test compilation approach with a more structured system using build scripts and test utilities.
Changes:
- Added
wasixcc_test_utils.rsproviding utilities for compiling and running WASIX tests - Refactored
context_switching.rsto use the new build script-based test approach - Added 19 new context switching test cases with corresponding C source files and build scripts
- Updated
.gitignoreto exclude build artifacts while preserving source files
Reviewed changes
Copilot reviewed 57 out of 76 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/wasix/tests/wasixcc_test_utils.rs | New test utility framework with compilation and execution helpers |
| lib/wasix/tests/context_switching.rs | Refactored to use build scripts instead of inline compilation |
| lib/wasix/tests/.gitignore | Updated patterns for new test structure |
| lib/wasix/tests/context_switching/*/build.sh | Simple build scripts for each test case |
| lib/wasix/tests/context_switching//.c | Comprehensive test cases for context switching scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
24d83e2 to
3a175c2
Compare
45a72a8 to
88b3497
Compare
88b3497 to
c43aea6
Compare
|
When running locally, I noticed a couple of failing tests due to: What am I missing? |
|
@marxin You are missing the compatible sysroot (which means a sysroot with libffi) |
How should I install it? |
marxin
left a comment
There was a problem hiding this comment.
Would be nice if we could get rid of tests/wasix/test.sh and port all the tests in the sub-folder to the new infrastructure.
|
@marxin I think it's a good idea to commit the new test files already |
Great, then please use the default format configuration. I don't care about the style itself at all (I only obey |
69026d4 to
e9ba585
Compare
Description