Add support for AWS Kinesis Enhanced Fan-Out as an input#669
Closed
jbeemster wants to merge 10 commits intowarpstreamlabs:mainfrom
Closed
Add support for AWS Kinesis Enhanced Fan-Out as an input#669jbeemster wants to merge 10 commits intowarpstreamlabs:mainfrom
jbeemster wants to merge 10 commits intowarpstreamlabs:mainfrom
Conversation
jem-davies
reviewed
Jan 29, 2026
Collaborator
jem-davies
left a comment
jem-davies
left a comment
There was a problem hiding this comment.
Had a quick scan through - will look more in-depth very soon ... Also could we downgrade the log calls to debug maybe - it seems that is what the rest of the code does?
Comment on lines
+388
to
+390
| if k.conf.EnhancedFanOut.ConsumerName != "" && k.conf.EnhancedFanOut.ConsumerARN != "" { | ||
| return nil, errors.New("cannot specify both consumer_name and consumer_arn in enhanced_fan_out config") | ||
| } |
Collaborator
There was a problem hiding this comment.
Could you add a LintRule for this? It will catch misconfiguration earlier if so.
jbeemster
force-pushed
the
efo-support
branch
from
bde5014 to
d966932
Compare
Contributor
Author
|
@jem-davies we have re-opened this PR now from our official company fork (apologies) - #680 Its the same code with some minor tweaks that we have found during our testing. Its looking stable now however! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new consumption mode for Kinesis with Enhanced FanOut support. What this lets us do is provide a dedicated consumption pipe for Bento instead of depending on shared polling.
As much as possible I have tried to re-use the existing Kinesis input architectures and have only added EFO in terms of consuming the events but checkpointing + batching have been left identical. Quite a lot of the logical patterns have also been copied from the polling implementation and then altered to support EFO.