Display conversation searches by agent run title#10968
Conversation
Co-Authored-By: Oz <[email protected]>
eead964 to
70ac400
Compare
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR wires agent_run_id through conversation-search subagent metadata, fetches ambient task titles through AgentConversationsModel, and renders conversation search targets as either conversation titles, agent run titles, or a fallback ID. I did not find a code-level correctness or security issue in the changed lines.
Concerns
- This is a user-facing rendering change, but the PR description says screenshots/videos were not captured. For this user-facing change, please include screenshots or a screen recording demonstrating it working end to end.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Co-Authored-By: Oz <[email protected]>
Co-Authored-By: Oz <[email protected]>
Description
Render conversation-search subagent calls that target
agent_run_idwith the searched child run title instead of treating the search as the current conversation.This PR:
agent_run_idfrom conversation-search subagent metadata.AgentConversationsModeland re-renders when task data arrives.agent run <id>when the run title is unavailable.warp_multi_agent_apito the branch from Add agent run ID to conversation search metadata warp-proto-apis#311.Depends on:
Linked Issue
No linked issue.
Testing
cargo fmt --checkcargo check -p warp --libPATH="/tmp/warp-corepack-bin:$PATH" cargo clippy -p warp --lib --all-features --tests -- -D warnings./script/runFull workspace clippy was attempted with
cargo clippy --workspace --all-targets --all-features --tests -- -D warnings; it is currently blocked by an unrelated duplicateDEFAULT_ONNX_MODELdefinition incrates/input_classifier/src/bin/evaluate.rswhennld_classifier_v2is enabled.Screenshots / Videos
Not captured.
Agent Mode
Plan: https://staging.warp.dev/drive/notebook/xj15fRX70pF0DtEyxohVMj
Conversation: https://staging.warp.dev/conversation/7ce46a9f-3d21-41d9-becb-67d8ab107f23
CHANGELOG-NONE
Co-Authored-By: Oz [email protected]