[APP-4491] Allow cloud agent view exit during long commands#10966
Draft
harryalbert wants to merge 3 commits into
Draft
[APP-4491] Allow cloud agent view exit during long commands#10966harryalbert wants to merge 3 commits into
harryalbert wants to merge 3 commits into
Conversation
Co-Authored-By: Oz <[email protected]>
…loud-mode-agent-exit Co-Authored-By: Oz <[email protected]>
Co-Authored-By: Oz <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cloud-mode panes can now exit agent view even while the active block is a long-running third-party agent command. The generic local-terminal guard still blocks exiting fullscreen agent view during local long-running commands, but Cloud Agent entries and ambient cloud-mode terminal views bypass that guard and either pop nested cloud panes or exit root cloud agent view in place.
Linked Issue
APP-4491
ready-to-specorready-to-implement.Testing
cargo fmt --all --checkcargo clippy -p warp --lib --all-targets -- -D warningscargo test -p warp escape_exits_root_cloud_agent_view_with_long_running_commandcargo test -p warp escape_pops_nested_cloud_agent_view_with_long_running_commandcargo test -p warp escape_does_not_exit_local_agent_view_with_long_running_command./script/runAgent Mode
CHANGELOG-BUG-FIX: Fixed cloud mode panes getting stuck in agent view while a third-party agent command is still running.
This PR was created by Oz (running Codex).