Skip to content

Comments

chore: fix bikeshed warnings#610

Merged
jyasskin merged 4 commits intomainfrom
fix_warnings
Jan 27, 2026
Merged

chore: fix bikeshed warnings#610
jyasskin merged 4 commits intomainfrom
fix_warnings

Conversation

@marcoscaceres
Copy link
Contributor

@marcoscaceres marcoscaceres commented Jan 22, 2026

Bikeshed was complaining about ambiguous links to the a element in HTML.


Preview | Diff

@jyasskin
Copy link
Contributor

jyasskin commented Jan 22, 2026

That's fun. We should actually add mathml-core to the 'ignored-specs' section, instead of adding all of the colliding elements. Want me to do that, or do you want to handle it?

@jyasskin jyasskin self-requested a review January 22, 2026 19:46
index.bs Outdated
Comment on lines 34 to 35
type:element; text:a
type:element-attr; for:a; text:href
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
type:element; text:a
type:element-attr; for:a; text:href

Copy link
Contributor

@jyasskin jyasskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, and then thank you!

@jyasskin jyasskin enabled auto-merge (squash) January 27, 2026 00:31
@jyasskin jyasskin merged commit 6ec7e11 into main Jan 27, 2026
1 check passed
@jyasskin jyasskin deleted the fix_warnings branch January 27, 2026 00:31
github-actions bot added a commit that referenced this pull request Jan 27, 2026
…ment (#610)

SHA: 6ec7e11
Reason: push, by jyasskin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants