fix: update blockscout verifier and improvement#422
Open
s3bc40 wants to merge 12 commits intovyperlang:masterfrom
Open
fix: update blockscout verifier and improvement#422s3bc40 wants to merge 12 commits intovyperlang:masterfrom
s3bc40 wants to merge 12 commits intovyperlang:masterfrom
Conversation
Tested againt Sepolia network with `test_verify` of `test_sepolia_env.py`.
- Updated the Blockscout verifier to use a session - Added a check to ensure the contract is created before verification - Removed unnecessary API key handling since Blockscout does not require it - Improved the integration test for the Blockscout verifier
…noboa into feat/ethercanv2-api-explorer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues:
What I did
Fix compatibility Blockscout APIs by introducing a unified session management utility, and updating the Blockscout verification logic to remove reliance on API keys.
How I did it
Updates to API Compatibility:
api_keyattribute from theBlockscoutclass and updated verification logic to check contract existence and verification status before proceeding. Introduced retries for contract creation using the session utility.Session Management Improvements:
get_sessioninboa/util/cached_session.pyto abstract session creation. This utility supports bothrequests_cacheand fallback to regularrequests.Session, enabling consistent session handling across the codebase.get_sessionutility inboa/explorer.pyandboa/verifiers.py.Test Case Updates:
How to verify it
Run the following test:
Description for the changelog
Cute Animal Picture