refactor: simplify merge function using maps.Copy from Go 1.21+#244
Open
slightsharp wants to merge 1 commit intovulpemventures:masterfrom
Open
refactor: simplify merge function using maps.Copy from Go 1.21+#244slightsharp wants to merge 1 commit intovulpemventures:masterfrom
slightsharp wants to merge 1 commit intovulpemventures:masterfrom
Conversation
Signed-off-by: slightsharp <slightsharp@outlook.com>
Author
|
@tiero Hi, Could you please review this PR at your convenience? Thank you very much. |
There was a problem hiding this comment.
Pull request overview
This PR refactors the internal state map-merging helper to use the standard library’s maps.Copy utility (Go 1.21+), reducing manual loop code while preserving behavior.
Changes:
- Replace the manual key-by-key merge loop with
maps.Copy. - Rename the variadic parameter from
mapstosourcesand the local accumulator frommergetoresultto avoid naming collisions and improve clarity. - Add the
mapsstandard library import.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a new function added in the go1.21 standard library, which can make the code more concise and easy to read.