Add useRole configuration option for Firebase App Hosting#1651
Add useRole configuration option for Firebase App Hosting#1651dherbst wants to merge 2 commits intovuejs:mainfrom
Conversation
When using Firebase App Hosting, can use role based authentication instead of setting GOOGLE_APPLICATION_CREDENTIALS env variable for vuejs#1636
📝 WalkthroughWalkthroughAdds a new boolean Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@packages/nuxt/src/module/options.ts`:
- Around line 48-53: Update the JSDoc above the useRole option to reference the
correct environment variable name: replace GOOGLE_ACCOUNT_CREDENTIALS with
GOOGLE_APPLICATION_CREDENTIALS in the comment for the useRole property so the
documentation matches the actual env var; locate the comment block immediately
preceding the useRole?: boolean declaration and edit its text accordingly.
Firebase App Hosting configures the backend server so that it can use Role based authentication instead of needing a file for GOOGLE_APPLICATION_CREDENTIALS. Therefore, it is not necessary for the nuxt-vuefire module to warn that the GAC environment variable is missing and not initialize the firebase application on the server side.
This PR adds a new configuration option to nuxt-vuefire to specify that the server is going to use role based authentication and the GOOGLE_APPLICATION_CREDENTIALS environment variable is not necessary.
This fixes issue #1636 when deploying to Firebase App Hosting so you do not need to add an additional unnecessary credential.
Summary by CodeRabbit
New Features
useRoleoption to enable role-based authentication for Firebase App Hosting (defaults to false).Documentation
✏️ Tip: You can customize this high-level summary in your review settings.