Add cluster helper functions for improved condition management by yoursanonymous · Pull Request #52 · volcano-sh/volcano-global

yoursanonymous · 2026-01-31T22:21:39Z

This PR adds reusable helper functions to pkg/utils/cluster.go to simplify cluster condition checks and reduce code duplication.

volcano-sh-bot · 2026-01-31T22:21:46Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign william-wang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

volcano-sh-bot · 2026-01-31T22:21:51Z

Welcome @yoursanonymous! It looks like this is your first PR to volcano-sh/volcano-global 🎉

gemini-code-assist · 2026-01-31T22:21:52Z

Summary of Changes

Hello @yoursanonymous, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the pkg/utils package by introducing a set of reusable helper functions for managing and querying Kubernetes cluster conditions. The changes aim to centralize condition-checking logic, making it more robust and easier to maintain, while also providing clearer APIs for determining a cluster's readiness status.

Highlights

Refactored CheckClusterReady function: The existing CheckClusterReady function in pkg/utils/cluster.go has been refactored to leverage a new helper function, improving modularity and readability.
New helper function GetClusterCondition: A new function GetClusterCondition has been introduced to safely retrieve a specific condition from a cluster's status, promoting code reuse and simplifying condition checks.
New helper function IsClusterReady: A new boolean helper function IsClusterReady has been added to provide a concise way to determine if a cluster is in a ready state.
Comprehensive Unit Tests: A new test file pkg/utils/cluster_test.go has been added, including comprehensive unit tests for the newly introduced GetClusterCondition, IsClusterReady, and the refactored CheckClusterReady functions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request refactors cluster condition checking by introducing helper functions GetClusterCondition and IsClusterReady, which improves code reuse and clarity. The changes are logical and well-tested. I've identified a few minor areas for improvement regarding code style and a small bug in one of the new tests.

gemini-code-assist · 2026-01-31T22:22:35Z

pkg/utils/cluster_test.go

+				},
+			},
+			ready:false,
+			message: "Cluster <not-ready-cluster> is not ready, reason: NetworkUnavailable, message: Network is down",


The expected error message has a space between Cluster and <not-ready-cluster>, but the implementation in CheckClusterReady produces a message without this space (Cluster<not-ready-cluster>...). This will cause the test to fail. The expected message should be updated to match the actual output for consistency and to ensure the test passes.

Suggested change

message: "Cluster <not-ready-cluster> is not ready, reason: NetworkUnavailable, message: Network is down",

message: "Cluster<not-ready-cluster> is not ready, reason: NetworkUnavailable, message: Network is down",

gemini-code-assist · 2026-01-31T22:22:35Z

pkg/utils/cluster.go

+}
+
+func IsClusterReady(cluster *clusterv1alpha1.Cluster) bool {
+	condition:=GetClusterCondition(cluster, string(clusterv1alpha1.ClusterConditionReady))


The explicit type conversion string(clusterv1alpha1.ClusterConditionReady) is redundant. The type clusterv1alpha1.ClusterConditionType is an alias for string, so it can be used directly where a string is expected. Removing the conversion makes the code slightly cleaner and more idiomatic.

Suggested change

condition:=GetClusterCondition(cluster, string(clusterv1alpha1.ClusterConditionReady))

condition:=GetClusterCondition(cluster, clusterv1alpha1.ClusterConditionReady)

gemini-code-assist · 2026-01-31T22:22:35Z

pkg/utils/cluster.go

+}
+
+func CheckClusterReady(cluster *clusterv1alpha1.Cluster) (bool, string) {
+	condition:=GetClusterCondition(cluster, string(clusterv1alpha1.ClusterConditionReady))


Similar to the comment on IsClusterReady, the explicit type conversion string(clusterv1alpha1.ClusterConditionReady) is redundant here as well and can be removed for better readability.

Suggested change

condition:=GetClusterCondition(cluster, string(clusterv1alpha1.ClusterConditionReady))

condition:=GetClusterCondition(cluster, clusterv1alpha1.ClusterConditionReady)

gemini-code-assist · 2026-01-31T22:22:35Z

pkg/utils/cluster_test.go

+)
+
+func TestGetClusterCondition(t *testing.T) {
+	readyType := string(clusterv1alpha1.ClusterConditionReady)


The explicit type conversion to string is not necessary here. clusterv1alpha1.ClusterConditionReady can be used directly. This also makes it consistent with how readyType is defined in TestIsClusterReady and TestCheckClusterReady within this same file.

Suggested change

readyType := string(clusterv1alpha1.ClusterConditionReady)

readyType := clusterv1alpha1.ClusterConditionReady

Signed-off-by: vinayak sharma <vinayaks0111@gmail.com>

yoursanonymous · 2026-02-06T07:16:58Z

@JesseStutler , Can you please review this pull request.

volcano-sh-bot requested review from JesseStutler and kevin-wangzefeng January 31, 2026 22:21

volcano-sh-bot added the size/L label Jan 31, 2026

gemini-code-assist bot reviewed Jan 31, 2026

View reviewed changes

yoursanonymous force-pushed the main branch from 7a5fdfe to a0ffec6 Compare January 31, 2026 22:36

Add cluster helper functions for improved condition management

2a503f0

Signed-off-by: vinayak sharma <vinayaks0111@gmail.com>

yoursanonymous force-pushed the main branch from a0ffec6 to 2a503f0 Compare February 1, 2026 08:24

main

ac8b16f

Signed-off-by: vinayak sharma <vinayaks0111@gmail.com>

yoursanonymous force-pushed the main branch from b428792 to ac8b16f Compare February 1, 2026 10:38

edits

d3df372

Signed-off-by: vinayak sharma <vinayaks0111@gmail.com>

yoursanonymous force-pushed the main branch from 4a84252 to d3df372 Compare February 3, 2026 13:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add cluster helper functions for improved condition management #52

Add cluster helper functions for improved condition management #52
yoursanonymous wants to merge 3 commits intovolcano-sh:mainfrom
yoursanonymous:main

yoursanonymous commented Jan 31, 2026

Uh oh!

volcano-sh-bot commented Jan 31, 2026

Uh oh!

volcano-sh-bot commented Jan 31, 2026

Uh oh!

gemini-code-assist bot commented Jan 31, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Jan 31, 2026

Uh oh!

gemini-code-assist bot Jan 31, 2026

Uh oh!

gemini-code-assist bot Jan 31, 2026

Uh oh!

gemini-code-assist bot Jan 31, 2026

Uh oh!

yoursanonymous commented Feb 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	message: "Cluster <not-ready-cluster> is not ready, reason: NetworkUnavailable, message: Network is down",
	message: "Cluster<not-ready-cluster> is not ready, reason: NetworkUnavailable, message: Network is down",

	condition:=GetClusterCondition(cluster, string(clusterv1alpha1.ClusterConditionReady))
	condition:=GetClusterCondition(cluster, clusterv1alpha1.ClusterConditionReady)

	readyType := string(clusterv1alpha1.ClusterConditionReady)
	readyType := clusterv1alpha1.ClusterConditionReady

Conversation

yoursanonymous commented Jan 31, 2026

Uh oh!

volcano-sh-bot commented Jan 31, 2026

Uh oh!

volcano-sh-bot commented Jan 31, 2026

Uh oh!

gemini-code-assist bot commented Jan 31, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

yoursanonymous commented Feb 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants